Fix/gizmos translation #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… view + first try to fix the translation
x64x2
approved these changes
Aug 3, 2024
adriengivry
reviewed
Aug 3, 2024
Sources/Overload/OvEditor/include/OvEditor/Core/GizmoBehaviour.h
Outdated
Show resolved
Hide resolved
adriengivry
reviewed
Aug 8, 2024
Co-authored-by: Adrien Givry <contact@adrien-givry.com>
…istent required offset Co-authored-by: Adrien Givry <contact@adrien-givry.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing Gizmos Translations
The Gizmos Translation operation was generating an increasing offset between the target and the mouse position. It's now fixed thanks to proper computations.
Due to the Gizmos's Shader that scale the Gizmos models depending of the camera distance it seems that the mouse is not sticking to the Gizmos arrow but that's a visual effect, there is no more undesirable offset.
Limitations
The current implementation does not handle properly when the object is really far from the camera, the translation is stopped due to the T multiplier value's behind 0. This statement is necessary to avoid the behavior where the target is coming back from the opposite translation direction, this can be certainly fixed easily but will require a better support math side to understand exactly where is the mistake in the current translation computation.
Screenshots
Related Issues
need to be created