Update item-view event, improve analytics debouncing #2289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In terms of quality of data, the current event style wasn't super useful since it spread the collections out into separate categories. This change makes separate events for each collection found, with the `category` field being updated. This way in GA we can count within each collection. Also, the way debouncing was working to help keep down the number of duplicate calls wasn't sufficient in most cases. This is because the debounce method doesn't care about whether the calls are actually duplicate just that they are being triggered in quick succession. So we were getting some lost events and still some duplicated. This commit sets up a simple debouncing-cache that has short-lived cache entries that are checked against incoming events to decide whether to block or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In terms of quality of data, the current event style wasn't super useful since it spread the collections out into separate categories.
This change makes separate events for each collection found, with the
categoryfield being updated. This way in GA we can count within each collection.Also, the way debouncing was working to help keep down the number of duplicate calls wasn't sufficient in most cases. This is because the debounce method doesn't care about whether the calls are actually duplicate just that they are being triggered in quick succession. So we were getting some lost events and still some duplicated.
This PR sets up a simple debouncing-cache that has short-lived cache entries that are checked against incoming events to decide whether to block or not.