Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update item-view event, improve analytics debouncing #2289

Merged
merged 1 commit into from
Mar 28, 2024

Commits on Mar 17, 2024

  1. Update item-view event, improve analytics debouncing

    In terms of quality of data, the current event style wasn't super useful since it spread the collections out into separate categories.
    
    This change makes separate events for each collection found, with the `category` field being updated.  This way in GA we can count within each collection.
    
    Also, the way debouncing was working to help keep down the number of duplicate calls wasn't sufficient in most cases.  This is because the debounce method doesn't care about whether the calls are actually duplicate just that they are being triggered in quick succession.  So we were getting some lost events and still some duplicated.
    
    This commit sets up a simple debouncing-cache that has short-lived cache entries that are checked against incoming events to decide whether to block or not.
    thostetler committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    20ae698 View commit details
    Browse the repository at this point in the history