Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(conf): need to remove projects setting before write #139

Merged
merged 1 commit into from
Dec 11, 2024
Merged

fix(conf): need to remove projects setting before write #139

merged 1 commit into from
Dec 11, 2024

Conversation

jmkerloch
Copy link
Collaborator

  • size was correct but previous project were kept

closes #138

@jmkerloch
fix(conf): need to remove projects setting before write
4f023b1 
- size was correct but previous project were kept
@jmkerloch jmkerloch self-assigned this Dec 11, 2024
@jmkerloch jmkerloch added the bug label Dec 11, 2024
@jmkerloch jmkerloch requested a review from Guts December 11, 2024 12:26
@jmkerloch jmkerloch marked this pull request as ready for review December 11, 2024 12:26
@jmkerloch jmkerloch mentioned this pull request Dec 11, 2024
Closed
2 tasks
Guts
Guts approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@Guts Guts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@jmkerloch jmkerloch merged commit 9ecdd46 into master Dec 11, 2024
8 checks passed
@jmkerloch jmkerloch deleted the fix/project_kept_in_settings branch December 11, 2024 12:39
@Guts Guts mentioned this pull request Dec 11, 2024
Merged
@jmkerloch jmkerloch added this to the 2.2.1 milestone Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Guts Guts Guts approved these changes

Assignees

@jmkerloch jmkerloch

Labels
bug
Projects
None yet
Milestone
2.2.1
Development

Successfully merging this pull request may close these issues.

Delete menu doesn't work
2 participants
@jmkerloch @Guts