Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(settings): invalid remove use we must indicate projects #142

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

jmkerloch
Copy link
Collaborator

closes #138

After some tests on Windows, there is an issue with the use of QgsSettings::remove. We need to indicate the name of the attribute to remove.

@jmkerloch jmkerloch self-assigned this Dec 11, 2024
@jmkerloch jmkerloch added the bug label Dec 11, 2024
@jmkerloch jmkerloch requested a review from Guts December 11, 2024 13:28
@Guts
Copy link
Collaborator

Guts commented Dec 11, 2024

After some tests on Windows

Only on Windows?

@jmkerloch
Copy link
Collaborator Author

After some tests on Windows

Only on Windows?

I tested this branch on Ubuntu also.

@Guts
Copy link
Collaborator

Guts commented Dec 11, 2024

Sure, I was asking why the bug is Windows-only?

So this PR is a following up of #139?

@jmkerloch
Copy link
Collaborator Author

Sure, I was asking why the bug is Windows-only?

So this PR is a following up of #139?

I guess the python version on the QGIS version that I tested was not compatible.

This is more a fix of #139. Sorry for the noise.

@jmkerloch jmkerloch added this to the 2.2.1 milestone Dec 11, 2024
@jmkerloch jmkerloch merged commit 42ad359 into master Dec 11, 2024
8 checks passed
@jmkerloch jmkerloch deleted the fix/invalid_settings_remove branch December 11, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete menu doesn't work
2 participants