Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.0 Updates #1

Merged
merged 48 commits into from
Dec 11, 2022
Merged

v1.0 Updates #1

merged 48 commits into from
Dec 11, 2022

Conversation

af-a
Copy link
Owner

@af-a af-a commented Dec 11, 2022

Description

This PR includes the following changes in preparation for the first official release of the package:

  • additional features, such as different emulation methods (e.g. using changes in absolute or log values, single or multi-channel change detection criteria, a pyDVS implementation, etc.)
  • updates and clean-up of the code
  • major improvements to the README

af-a added 30 commits October 11, 2021 17:24
@af-a
Change structure of python module (avoids issues with potential ROS c…
75da75f 
…ustom messages)
@af-a
Update README
470d89f
@af-a
Add theta and record_off_events launch args
d1ee35e
@af-a
[event_image_streamer] Adjust topic names and add check for invalid s…
81880d4 
…ource type
@af-a
[event_image_streamer] Add timestamp to event image messages
c75580a
@af-a
[event_image_streamer] Change python to python3
d8ab092
@af-a
[event_image_streamer] Temporarily remove rate.sleep, since it clashe…
de047e2 
…s with cv windows
@af-a
Add compute_from_rgb parameter
1e89b20
@af-a
Remove unused roscpp from CMakeLists.txt
535edde
@af-a
Set preferred param defaults in stream_camera_events.py
6c018a6
@af-a
Revert "[event_image_streamer] Temporarily remove rate.sleep, since i…
e46eac2 
…t clashes with cv windows"

This reverts commit de047e2.
Although this clash still exists, the sleep is needed to limit the
publish rate of events. The output can be observed from published
messages instead of cv windows for now.
@af-a
Add experimental binary event generation
9d30b25 
A rudimentary (more correct) implementation of event generation, in
which event frames have ON/OFF signals, instead of grayscale
intensities. In addition, a helper function can convert this to a format
for viewing as before.
@af-a
[event_image_streamer] Add separate publishing of visual_events_images
6e98832
@af-a
Fix bug: node dying if received msgs re-start publishing
fd05b26 
rospy's sleep was throwing a hitherto uncaught
ROSTimeMovedBackwardsException the moment published msgs where published
again after stopping (e.g. after restarting the simulation). This killed
the node immediately.
@af-a
Add explicit flag for registering OFF events as ON
74c2305 
This is mainly to account for the fact that the SNN output produced and
used in the Park PF vel output decoding method works best when the OFF
events are simply registered as ON events in the ECE, before resizing
and interpreting the events image elsewhere (which is done later).
@af-a
Add initial implementation of log-diff-based event emulation
3ae151c
@af-a
Add rough implementation of salvatore's method for log-based event em…
4e188d7 
…ulation
@af-a
Add initial version of a pyDVS-based event image streamer
9e125e8
@af-a
[pydvs_event_image_streamer] Remove square resolution constraint
2e1e113
@af-a
[pydvs_event_image_streamer] Remove some unnecessary code and comments
db2fc8a
@af-a
[pydvs_event_image_streamer] Modify spike queue handling
3d53b5b
@af-a
[pydvs_event_image_streamer] Obtain height and width dims from input
cf5b05a
@af-a
[pydvs_event_image_streamer] Some changes to parameters and initializ…
f47c2fe 
…ation
@af-a
[event_image_streamer] Add optional combination of raw and event data…
79b0263 
… in one visualized image
@af-a
[pydvs_event_image_streamer] Remove inapplicable and currently unused…
d0daed3 
… ros params
@af-a
[pydvs_event_image_streamer] Rectify node name
ec157f9
@af-a
Add stream_pydvs.launch
16cb296
@af-a
[pydvs_event_image_streamer] Correct setting of OFF events (to match …
4f46913 
…event_image_streamer)
@af-a
[stream_pydvs] Add record_off_events and register_off_events_as_on pa…
0a0fa3f 
…rams
@af-a
Add optional image blurring in emulator and ros node (experimental)
984c648
af-a and others added 18 commits May 1, 2022 14:29
@af-a
[emulator] Improve function names
9d1ee0a
@af-a
Add optional data saving to streamer nodes and launch files
18e3f8f
@af-a
Add temp data saving on trigger (for thesis tests)
81144a3
@af-a
Remove absolute paths in default args in scripts and launch files
13441f2
@af-a
Update stream_camera_events.py
34f8c57
@af-a
Clean up emulator.py (minor)
8d03983
@af-a
Update email address in package.xml
dd6a55f
@af-a
[package.xml] Remove roscpp dependency
3a7a9ef
@af-a
Update parameter defaults in launch files
79b5d72
@af-a
[stream_camera_events] Minor updates to sample script
49d0443
@af-a
[emulator] Update salvatore method citation in function docstrings
68eeec8
@af-a
[event_image_streamer] Remove functionality: reporting avg computatio…
71a737c 
…n time
@af-a
Some clean-up (param defaults, removing old comments, etc.)
acf6bff
@af-a
[event_image_streamer] Remove unused imports
fe5e67f
@af-a
[pydvs_event_image_streamer] Update and clean-up node
42125e5
@af-a
Add ece logo image
1338080
@af-a
Add demo GIF and media directory
b54998c
@af-a
Add improved and updated README
b5c4c43
@af-a af-a merged commit 54471ea into main Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@af-a