Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storage): rename conversions #1407

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Conversation

joseivanlopez
Copy link
Contributor

@joseivanlopez joseivanlopez commented Jun 27, 2024

  • Rename conversions from ToSchema and FromSchema to ToJSON and FromJSON.
  • The namespaces ProposalSettingsConversion and VolumeConversion are renamed as ProposalSettingsConversions and VolumeConversions.
  • Conversion methods are moved from the namespace modules to the ProposalSettings and Volume classes.

Note: conversions under Agama::DBus::Storage namespace are not modified because they are going to be removed in future iterations.

@joseivanlopez joseivanlopez changed the title fix(storage): rename schema conversion fix(storage): rename conversions Jun 27, 2024
@joseivanlopez joseivanlopez force-pushed the rename-schema-conversion branch from 313eb6b to 3510980 Compare June 28, 2024 05:47
@joseivanlopez joseivanlopez force-pushed the rename-schema-conversion branch 4 times, most recently from 3616df4 to c2afbe5 Compare June 28, 2024 08:37
@joseivanlopez joseivanlopez force-pushed the rename-schema-conversion branch from c2afbe5 to a3bc41e Compare June 28, 2024 08:42
@coveralls
Copy link

Coverage Status

coverage: 71.4% (-0.01%) from 71.41%
when pulling a3bc41e on rename-schema-conversion
into accf894 on master.

@joseivanlopez joseivanlopez changed the title fix(storage): rename conversions chore(storage): rename conversions Jun 28, 2024
@joseivanlopez joseivanlopez marked this pull request as ready for review June 28, 2024 08:59
@joseivanlopez joseivanlopez merged commit fc04e35 into master Jun 28, 2024
6 checks passed
@joseivanlopez joseivanlopez deleted the rename-schema-conversion branch June 28, 2024 10:26
@imobachgs imobachgs mentioned this pull request Sep 20, 2024
imobachgs added a commit that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants