Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): more accurate info about resizing #1428

Merged
merged 12 commits into from
Jul 9, 2024

Conversation

joseivanlopez
Copy link
Contributor

@joseivanlopez joseivanlopez commented Jul 2, 2024

Problem

The information about resizing devices shown by the UI for finding free space is not 100% accurate. Sometimes it allows selecting to resize a device but the device cannot be resized.

Solution

  • D-Bus provides more accurate information about resizing.
  • The UI does not allow selecting "resize" if the device cannot be resized.
  • The UI offers a button to show information about the device (either reasons why it cannot be shrunk or total shrinkable size).
Toggle screenshots

localhost_8080_ (15)

localhost_8080_ (16)

localhost_8080_ (17)

@joseivanlopez joseivanlopez force-pushed the resize-improvements branch from b195932 to daadd77 Compare July 4, 2024 15:37
@coveralls
Copy link

Coverage Status

coverage: 71.382% (-0.03%) from 71.408%
when pulling daadd77 on joseivanlopez:resize-improvements
into 7101d0d on openSUSE:master.

@joseivanlopez joseivanlopez changed the title feat(stoage): more accurate info about resizing feat(storage): more accurate info about resizing Jul 5, 2024
@coveralls
Copy link

Coverage Status

coverage: 71.382% (-0.03%) from 71.408%
when pulling 12b276c on joseivanlopez:resize-improvements
into 7101d0d on openSUSE:master.

@coveralls
Copy link

Coverage Status

coverage: 71.382% (-0.03%) from 71.408%
when pulling 12b276c on joseivanlopez:resize-improvements
into 7101d0d on openSUSE:master.

@joseivanlopez joseivanlopez force-pushed the resize-improvements branch 2 times, most recently from 3befc15 to 23f7ee5 Compare July 5, 2024 13:12
@joseivanlopez joseivanlopez marked this pull request as ready for review July 5, 2024 13:30
Copy link
Contributor

@imobachgs imobachgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, just some minor comments (and a small bug).

rust/agama-lib/src/storage/model.rs Outdated Show resolved Hide resolved
service/lib/agama/storage/device_shrinking.rb Outdated Show resolved Hide resolved
service/test/agama/storage/device_shrinking_test.rb Outdated Show resolved Hide resolved
Copy link
Contributor

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @joseivanlopez! Web front-end part LGTM 👍

web/src/components/storage/SpaceActionsTable.test.jsx Outdated Show resolved Hide resolved
@ancorgs

This comment was marked as resolved.

@ancorgs

This comment was marked as resolved.

@joseivanlopez
Copy link
Contributor Author

Shouldn't we also honor DeviceShrinking at the proposal settings conversion when :resize is chosen as policy?

I fear that piece of code can generate potentially dangerous :resize actions that wouldn't be accepted if configured manually. Or are we maybe safe because the proposal will ignore those? If that's the case, I would like to at least see a comment about it.

I fear we are not safe in all scenarios. For example, I was able to resize a device with closed LUKS.

@joseivanlopez joseivanlopez force-pushed the resize-improvements branch from c42092e to a4a9436 Compare July 8, 2024 12:42
@coveralls
Copy link

coveralls commented Jul 8, 2024

Coverage Status

coverage: 71.389% (-0.02%) from 71.408%
when pulling 8d4d7c2 on joseivanlopez:resize-improvements
into 05e7963 on openSUSE:master.

@joseivanlopez joseivanlopez force-pushed the resize-improvements branch from eaffa72 to ffb2b8f Compare July 8, 2024 14:28
@joseivanlopez joseivanlopez force-pushed the resize-improvements branch from ffb2b8f to 8d4d7c2 Compare July 8, 2024 14:31
Copy link
Contributor

@ancorgs ancorgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joseivanlopez joseivanlopez merged commit 157adae into agama-project:master Jul 9, 2024
5 checks passed
@imobachgs imobachgs mentioned this pull request Sep 20, 2024
imobachgs added a commit that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants