Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make it work with the agda stdlib v2.0 (c12568c64) #352

Closed
wants to merge 2 commits into from

Conversation

cmcmA20
Copy link
Contributor

@cmcmA20 cmcmA20 commented Jun 30, 2022

^subj

@MatthewDaggitt
Copy link
Contributor

A heads up that v2.0 is not released so I wouldn't recommend merging this in, unless you want your users to have to upgrade to the unstable library version.

@cmcmA20
Copy link
Contributor Author

cmcmA20 commented Jun 30, 2022

Let it chill until then, I will update it after release.

@cmcmA20 cmcmA20 marked this pull request as draft June 30, 2022 09:39
@JacquesCarette
Copy link
Collaborator

I think that release of v2.0 might be pretty soon, so it might be worth revisiting this now-ish to be ready for it.

@cmcmA20
Copy link
Contributor Author

cmcmA20 commented Jun 1, 2023

Tested with agda master 269204b682
Works on agda-stdlib master 7c5f3ff90

@JacquesCarette
Copy link
Collaborator

Thanks. [Note: there seems to be two outstanding conflicts?]

@cmcmA20
Copy link
Contributor Author

cmcmA20 commented Jun 1, 2023

Sorry I forgot to rebase, now it's fine.
agda-lib file conflict can't be resolved, I tested only 2.0 and not 1.7.2.
Do you wanna wait for 2.0?

@JacquesCarette
Copy link
Collaborator

Very nice work - I will take it in as soon as 2.0 becomes live.

It would be nice to have the same setup here as stdlib does (i.e. have an experimental branch where this could go in right away), I've just never had the time to prep the infrastructure.

@JacquesCarette
Copy link
Collaborator

So now that stdlib 2.0 is 'essentially' live, it would be nice to revisit this. Looks like things have broken since this was last looked at.

@cmcmA20
Copy link
Contributor Author

cmcmA20 commented Dec 5, 2023

The changes are extensive, I'll take a look during the weekend.

@JacquesCarette
Copy link
Collaborator

If you give me permission to push to your branch, I can help.

This was referenced Dec 13, 2023
@JacquesCarette
Copy link
Collaborator

In the end, 64 different places needed to be fixed to push things to 2.0, and this was done in #406 which has been merged. So this one is no longer needed - but keep PRs coming!

@JacquesCarette JacquesCarette deleted the agda_2.6.2_stdlib_2.0 branch December 26, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants