Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump stdlib to 2.0 #406

Merged
merged 68 commits into from
Dec 26, 2023
Merged

Bump stdlib to 2.0 #406

merged 68 commits into from
Dec 26, 2023

Conversation

Taneb
Copy link
Member

@Taneb Taneb commented Dec 13, 2023

Closes #405. Supercedes #352.

I ran into difficulty trying to make Categories.Yoneda work with the new function hierarchy so I'm opening this as a draft.

Many of the changes could be made tidier.

Difficulties encountered so far:

  • Categories.Category.Instance.Setoids and Categories.Adjoint.Mate could both do with a definition of equality of functions between setoids. I've inlined it for the former but didn't for the latter, because we just want the relation and it'd be too much of a mess to define it there locally too.
  • I got sufficiently confused by Categories.Yoneda that I bounced off it. I may give this another go at some point.

Other maintainers of the library are explicitly invited to contribute to this PR.

Didn't notice that I'd ended up in Functor.Instance in the previous commit
I couldn't get the proofs working with Surjective yesterday so I used SplitSurjective instead but that turned out to be too strict later
@Taneb
Copy link
Member Author

Taneb commented Dec 16, 2023

Status: I've been working through the modules in alphabetical order. I've skipped Categories.Adjoint.Mate because it would hugely benefit from having a definition of equality of functions between setoids somewhere, and its dependents. Currently up to Categories.Category.Instance.FamilyOfSetoids, but I won't have much time to work on it in the next few days

@Taneb Taneb marked this pull request as ready for review December 22, 2023 11:43
@Taneb
Copy link
Member Author

Taneb commented Dec 22, 2023

Wow, @JacquesCarette, you've stormed through that!

@JacquesCarette
Copy link
Collaborator

I ended up spending close to 12 hours yesterday single-mindedly pushing through this. I'd definitely appreciate a review @Taneb . I know there's quite a few things to clean up, but that's so much easier than the first pass.

Copy link
Member Author

@Taneb Taneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've had a quick look through and highlighted (all minor) problems I've seen.

Can I ask you to take a close look at Categories.Functor.Properties, @JacquesCarette ? It probably has the most substantial changes

src/Categories/Adjoint/Parametric.agda Outdated Show resolved Hide resolved
src/Categories/Category/Instance/FamilyOfSetoids.agda Outdated Show resolved Hide resolved
src/Categories/Category/Instance/FamilyOfSetoids.agda Outdated Show resolved Hide resolved
src/Categories/Category/Instance/Setoids.agda Outdated Show resolved Hide resolved
src/Categories/Functor/Properties.agda Outdated Show resolved Hide resolved
@JacquesCarette
Copy link
Collaborator

(I'm going to use the review facility to leave additional notes for myself)

Copy link
Collaborator

@JacquesCarette JacquesCarette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Various notes to help in a cleanup

src/Categories/Adjoint.agda Outdated Show resolved Hide resolved
src/Categories/Adjoint/Equivalents.agda Outdated Show resolved Hide resolved
src/Categories/Category/Closed.agda Show resolved Hide resolved
src/Categories/Category/Concrete/Properties.agda Outdated Show resolved Hide resolved
src/Categories/Category/Instance/Setoids.agda Outdated Show resolved Hide resolved
src/Categories/Category/Monoidal/Closed/IsClosed.agda Outdated Show resolved Hide resolved
src/Categories/CoYoneda.agda Outdated Show resolved Hide resolved
src/Categories/CoYoneda.agda Show resolved Hide resolved
src/Categories/Functor/Properties.agda Outdated Show resolved Hide resolved
@JacquesCarette JacquesCarette merged commit aee4189 into master Dec 26, 2023
1 check passed
@JacquesCarette JacquesCarette deleted the bump-stdlib-2.0 branch December 26, 2023 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support stdlib 2.0
2 participants