Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for Webpack #8

Merged
merged 2 commits into from
Jun 14, 2019
Merged

Add a test for Webpack #8

merged 2 commits into from
Jun 14, 2019

Conversation

agilgur5
Copy link
Owner

  • (test): add a similar webpack test as well
  • (test): run tests together in test script

Resolves-ish #7 (doesn't solve the loader bug discovered in that issue). Builds on top of #5 and #4

- setup import, export, and spec virtually the same as browserify
- run webpack in dev mode to speed up the build significantly
  - dev mode matches browserify's default too
  - might be able to disable some other 0CJS transforms but speed is
    fine for now

(deps): add webpack, webpack-cli, and worker-loader
- also add a clean script too
  - make the build/ folder in the process as it needs to exist for
    outputting the bundles

- probably want to extract these to a maidfile soon
Copy link
Owner Author

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not much to see here

@agilgur5 agilgur5 merged commit b513fe5 into master Jun 14, 2019
@agilgur5 agilgur5 deleted the webpack-test branch June 14, 2019 04:07
@agilgur5 agilgur5 mentioned this pull request Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant