Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable more powerful vesting accounts #82

Merged
merged 3 commits into from
Jul 27, 2021
Merged

Conversation

JimLarson
Copy link

@JimLarson JimLarson commented Jul 23, 2021

Expand the LockedCoins() method to take a full sdk.Context.

Description

Used in support of Agoric/agoric-sdk#3277 where a new type of "vesting account" will query to the Agoric swingset layer to see if there are any outstanding liens. Needs the full sdk.Context to do so.

Not marking as a breaking change, since this interface is not for general consumption.

Author Checklist

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Expand the LockedCoins() method to take a full sdk.Context.
@JimLarson JimLarson requested review from michaelfig and zmanian July 23, 2021 22:12
@JimLarson JimLarson added the enhancement New feature or request label Jul 23, 2021
@JimLarson JimLarson changed the title !feat: enable more powerful vesting accounts feat: enable more powerful vesting accounts Jul 23, 2021
@JimLarson JimLarson self-assigned this Jul 23, 2021
Copy link
Collaborator

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Very clear.

@JimLarson JimLarson merged commit ff4acfe into Agoric Jul 27, 2021
@JimLarson JimLarson deleted the jim-vesting-context branch July 27, 2021 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants