feat: export AccountKeeper interface instead of concrete type #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
approved these changes
Jul 27, 2021
x/auth/ante/ante.go
Outdated
Comment on lines
7
to
14
| "github.com/cosmos/cosmos-sdk/x/auth/keeper" | ||
| authsigning "github.com/cosmos/cosmos-sdk/x/auth/signing" | ||
| "github.com/cosmos/cosmos-sdk/x/auth/types" | ||
| ) | ||
|
|
||
| // HandlerOptions are the options required for constructing a default SDK AnteHandler. | ||
| type HandlerOptions struct { | ||
| AccountKeeper AccountKeeper | ||
| AccountKeeper keeper.AccountKeeper |
There was a problem hiding this comment.
Please revert the changes to this file. AccountKeeper is found in x/auth/ante/expected_keepers.go, so there should be no reason to import the full keeper.AccountKeeper interface.
JimLarson
force-pushed
the
jim-account-keeper-if
branch
from
ebf186e to
4c6c348
Compare
Allows use of any implementation that meets the interface. Will be used to wrap and selectively override methods.
JimLarson
force-pushed
the
jim-account-keeper-if
branch
from
4c6c348 to
c506ce9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To assist in creating an
AccountKeeperwrapper, exportAccountKeeperas an interface and keep the concrete implementation local to its module.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change