Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from isomorphic-fetch to fetch-everywhere (React Native support) #120

Closed
wants to merge 2 commits into from

Conversation

aarondancer
Copy link

This pull request replaces isomorphic-fetch with fetch-everywhere to support React Native. React Native support has been requested in these issues: #119 #111 #106

@aarondancer aarondancer changed the title Migrate from isomorphic-fetch to fetch-everywhere Migrate from isomorphic-fetch to fetch-everywhere (React Native support) Mar 7, 2017
@coveralls
Copy link

coveralls commented Mar 7, 2017

Coverage Status

Coverage decreased (-0.7%) to 99.273% when pulling ec5d169 on makeshopio:master into e72ac27 on agraboso:master.

@mlippens
Copy link

I think an import of fetch should be removed. According to the specs, fetch is supposed to be global, and therefore my vote goes out to do it that way as well. Let fetch be global, and let redux-middleware-api use the global. That way anyone can choose for his own environment what polyfill to use.

@agraboso
Copy link
Owner

agraboso commented May 1, 2017

The next branch (which will lead to version 2) removes isomorphic-fetch in favor of the global fetch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants