Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace isomorphic-fetch dependency by fetch-everywhere #1043

Closed
wants to merge 1 commit into from

Conversation

jpoutrin
Copy link

@jpoutrin jpoutrin commented May 4, 2017

I came across some nasty issue on react native.
here is a solution that was suggested in some other projects.

tests are passing fine.

…pported dev environments - react-native etc...
@webron webron requested a review from buunguyen May 4, 2017 15:57
@buunguyen
Copy link
Contributor

Hi, thanks for the PR. I want to make sure I understand the motivation of the lib change. Did you mean the old lib doesn't support React Native? Or what is the issue?

@jpoutrin
Copy link
Author

jpoutrin commented May 6, 2017

@buunguyen yes the current does not support react native
the solution was inspired by agraboso/redux-api-middleware#120
the current implementation does not initialize some global variables properly.

@jpoutrin
Copy link
Author

jpoutrin commented May 8, 2017

@buunguyen please do not merge the change.
The issue seems deeper than that.
I messes up the final react-native bundle for some reason.
it seems to be a webpack bundling issue. (one might not exclude the other).
I am no expert in webpack so this should be put on hold or discarded...

symptoms in my app when debugging:
Failed to print error: regeneratorRuntime.async is not a function

symptoms without:
client.apis is empty

if someone has an idea would appreciate.

sorry for that.

@jpoutrin
Copy link
Author

jpoutrin commented May 8, 2017

I opened an issue for this:
#1047

@buunguyen buunguyen closed this May 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants