-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate Site ID #259
Comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@rsparker-utah What do you think about changing the F to S in the ID since we mostly refer to the parent location as Site rather than Facility in the app? It will also provide a quick visual identification of records in the database that came from the app versus those that were pre-app. |
@nathankota I ran this by our UIC group and we all thought this makes sense. We are for this idea. |
@nathankota this is 7 requests bundled up in one. I'll take the liberty to add the field to the review page where it seems to fit. The report page is the same page printed right? Is the ARB letter still relevant? The last one is probably handled by another issue. Do you agree? |
I struggled with lumping vs splitting, and went with the former to keep it all together and tight. If it doesn't work as well for you, I will use it as a lesson for the future.
👍
Yes, with layout updates eventually via #273
Yes ref: #282
I'll put it in #284 so it doesn't get lost, and remove it from here. |
@rsparker-utah, I tested this a bit and it looks good to me, but I'd appreciate your further validation that it is ready to close. In particular, I kept an eye on the ID format, particularly FIPS. It looks like it's showing up in all the right places, with ABR still to come (#282). |
@rsparker-utah please confirm that this works as expected |
Tested and validated on the following sites/inventories: |
Site ID format:
The text was updated successfully, but these errors were encountered: