Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inventory Report layout #273

Closed
nathankota opened this issue Oct 11, 2023 · 22 comments · Fixed by #387
Closed

Inventory Report layout #273

nathankota opened this issue Oct 11, 2023 · 22 comments · Fixed by #387
Assignees
Labels
client feedback External feedback is desired. Please comment ASAP help wanted Extra attention is needed inventory review Stuff that happens during the admins' inventory review process

Comments

@nathankota
Copy link

nathankota commented Oct 11, 2023

Using the mockup document as a guide (page 2 of the doc, onward).
(Side note: The PLSS app's monument record sheet was the inspiration for the report layout and design.)

First Page(s)

  • Title (see mockup doc)
  • Site details (name, location, land ownership, naics, edocs, site ID
  • Inventory details (inventory class, order number, signed by, signed on (date))
  • Site contacts: separate table for each contact (name, org, type, email, phone, address)
    • multiple site contacts may cause this section to go beyond a single page

New page

  • Title: Location Details
  • Map showing the site, wells, SWPZ and ARDA (if applicable to the inventory)
    • Label wells with their name/construction
    • Show source water protection zone layer as 50% transparent, and label with SYSNAME
    • Show aquifer recharge discharge areas as 50% transparent, different color than SWPZ, and label with ZONE

New page

  • Well information section table including a record for each well (count, construction, operating status, groundwater indicators (GWZ, ARDA)
  • Water system information section (water system name, contact name, contact email)

New page

  • Title: Well Construction Details
  • One section per well
    • Show well name and Construction details text in each section
    • If document was uploaded, include text “See Appendix”
      • Append the construction details document at end of report
      • If multiple wells have the same uploaded document, only append the document once

New page

  • Title: Well Injectate Characterization
  • One section per well
    • Show well name and injectate characterization text in each section
    • If document was uploaded, include text “See Appendix”
      • Append the injectate characterization document at end of report
      • If multiple wells have the same uploaded document, only append the document once

New page

  • Title: Well Hydrogeologic Characterization
  • One section per well
  • Show well name and hydrogeologic characterization text in each section (no doc uploads allowed for this section)

Last page(s)

  • Title for each appended doc section, and the documents appended within the subsequent pages
    • Appendix 1: Well Construction Details
    • Appendix 2: Well Injectate Characterization
@nathankota nathankota added the inventory review Stuff that happens during the admins' inventory review process label Oct 11, 2023
@nathankota nathankota mentioned this issue Nov 6, 2023
5 tasks
@steveoh steveoh self-assigned this Nov 7, 2023
@nathankota nathankota changed the title Update inventory report layout Inventory Report layout Nov 14, 2023
@steveoh
Copy link
Member

steveoh commented Nov 21, 2023

are we running a footer like plss's

image

@steveoh

This comment was marked as outdated.

@nathankota

This comment was marked as outdated.

@steveoh

This comment was marked as outdated.

@nathankota nathankota added client feedback External feedback is desired. Please comment ASAP waiting labels Nov 27, 2023
@nathankota
Copy link
Author

DWQ team is currently reviewing and we expect feedback shortly.

@steveoh
Copy link
Member

steveoh commented Nov 30, 2023

This is the most recent iteration. uic-form-sample.pdf

@nathankota
Copy link
Author

@rsparker-utah 👀

This is the most recent iteration. uic-form-sample.pdf

@rsparker-utah
Copy link
Collaborator

This is looking great! We had a few comments from our review:

  1. Could the email field be added for each of the contacts on page 1 under the "Site Contacts" section?
  2. Could the "Contat" label be updated to "Contact" on page 3 under the "Water System Information" section?
  3. The review group liked the idea of including a disclaimer footer. Provided it's ok to do so, would we be able to reuse the footer from plss for this application as well: The state of Utah makes no guarantees, representations, or warranties of any kind, expressed or implied, as to the content, accuracy, timeliness, or completeness of any of the data. Unless otherwise noted all images are oriented North and are not to scale. The data is provided on an “as is, where is” basis. The State assumes no obligation or liability for its use by any persons.

@steveoh
Copy link
Member

steveoh commented Nov 30, 2023

Yes the email can be added. It's in there now and the spelling mistake is also corrected.

Provided it's ok to add the footer... who decides if it's ok?

@rsparker-utah
Copy link
Collaborator

@nathankota Do you know if it's ok for us to reuse the plss footer verbiage? If we're unsure, I can write something up.

@nathankota
Copy link
Author

@nathankota Do you know if it's ok for us to reuse the plss footer verbiage? If we're unsure, I can write something up.

@rsparker-utah The disclaimer can be whatever you want/need it to be. I don't know of any use restrictions of the PLSS verbiage, but your team or legal representative (Cate?) would be better at answering whether it's appropriate for this particular app and data. You tell us what you want in there and we'll do it :)

@rsparker-utah
Copy link
Collaborator

Ok, gotcha, that sounds good. Our review group seemed to like the plss verbiage, but I better run it by Cate first. Let's hold of on that piece for time being. I'll provide an update after I chat with Cate.

@steveoh
Copy link
Member

steveoh commented Nov 30, 2023

I've got this in there now...

image

I removed the page numbers because the user uploaded pdfs won't also have them and then it will be confusing

@rsparker-utah
Copy link
Collaborator

rsparker-utah commented Dec 6, 2023

I ran the disclaimer by our Data Management Specialist and have an update regarding the disclaimer. Could we add a sentence at the end of the existing disclaimer so it reads:

The State of Utah makes no guarantees, representations, or warranties of any kind, expressed or implied, as to the content, accuracy, timeliness, or completeness of any of the data. Unless otherwise noted all images are oriented North and are not to scale. The data is provided on an “as is, where is” basis. The State assumes no obligation or liability for its use by any persons. Identified inaccuracies can be reported to uic-inventory@utah.gov.

@nathankota nathankota removed waiting client feedback External feedback is desired. Please comment ASAP labels Dec 7, 2023
steveoh added a commit that referenced this issue Dec 13, 2023
steveoh added a commit that referenced this issue Dec 13, 2023
steveoh added a commit that referenced this issue Dec 13, 2023
steveoh added a commit that referenced this issue Dec 13, 2023
steveoh added a commit that referenced this issue Dec 13, 2023
steveoh added a commit that referenced this issue Dec 13, 2023
@steveoh
Copy link
Member

steveoh commented Dec 13, 2023

I've pushed the work I have done so far to dev. Please test it and see what you think. The appendix files are not currently being fetched and attached. Otherwise I think we have everything in the report that was in the mockup. Make sure your browser allows a popup.

@steveoh steveoh added help wanted Extra attention is needed client feedback External feedback is desired. Please comment ASAP labels Dec 13, 2023
@nathankota
Copy link
Author

As far as report layout, it looks correct/accurate/great to me. @rsparker-utah we now defer to you for final validation.

@steveoh
Copy link
Member

steveoh commented Dec 15, 2023

the well detail pdf's are now appended to the report. I deleted all of the cloud storage to remove any non pdf files. When you test you will need to update the well details for the inventory you are testing to add new files.

@rsparker-utah
Copy link
Collaborator

I created a new test site (i.e., https://uic-inventory.dev.utah.gov/review/site/118/inventory/212), submitted an inventory, and downloaded the Inventory Report. I think the report layout looks great! I did have a couple review comments:

1.) On page 3 of the report, it looks like the "Construction" field isn't populating in the table under "Well Information".
image
2.) Also it looks like the GWZ indicator functionality may not be working in the app which is carrying over to the Inventory Report. For example, on page 3 of the report, the site should be in a GWZ, but the GWZ indicator in the report appears to be red:
image
image

@steveoh
Copy link
Member

steveoh commented Dec 18, 2023

construction is fixed

image

We should track any GWZ issues in a new issue

@steveoh
Copy link
Member

steveoh commented Dec 18, 2023

Drinking water changed their service url. I've got that fixed now also. These are all the well ids that failed

image

@nathankota
Copy link
Author

@rsparker-utah please give this another try

@rsparker-utah
Copy link
Collaborator

I did a new round of testing on a new site (i.e., https://uic-inventory.dev.utah.gov/review/site/119/inventory/213), submitted an inventory, and downloaded the Inventory Report. I didn't come across any issues and I think the report layout looks really good! Thanks Steve!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client feedback External feedback is desired. Please comment ASAP help wanted Extra attention is needed inventory review Stuff that happens during the admins' inventory review process
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants