Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add action to check if version changed correctly #35

Merged
merged 4 commits into from
Oct 23, 2023
Merged

feat: add action to check if version changed correctly #35

merged 4 commits into from
Oct 23, 2023

Conversation

domire8
Copy link
Member

@domire8 domire8 commented Oct 19, 2023

Description

This PR solves the issue by moving the relevant code snippet into its own action so it can be reused in other places, for example

Review guidelines

Estimated Time of Review: 5 minutes

Checklist before merging:

  • Confirm that the relevant changelog(s) are up-to-date in case of any user-facing changes

@domire8 domire8 linked an issue Oct 19, 2023 that may be closed by this pull request
Create separate action to ensure semver #34
Closed
@domire8
Copy link
Member Author

domire8 commented Oct 19, 2023

This has been tested now

@domire8 domire8 merged commit b3a44ae into main Oct 23, 2023
@domire8 domire8 deleted the feature/semver branch October 23, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjenscodee jjenscodee jjenscodee approved these changes

@LouisBrunner LouisBrunner Awaiting requested review from LouisBrunner

@eeberhard eeberhard Awaiting requested review from eeberhard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create separate action to ensure semver
2 participants
@domire8 @jjenscodee