Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: prepare workflows for deletion of develop branch #58

Merged
merged 4 commits into from
Oct 23, 2023

Conversation

domire8
Copy link
Member

@domire8 domire8 commented Oct 19, 2023

Description

As we have done across almost all our stack, it would be nice to delete develop branch and work off main branch. For that, the workflows have to be updated. From now on, main will require linear history (right?).

The workflows follow these rules:

  • We no longer set the version with each commit by default, only when we want to release a change
  • Workflow would build and push rolling if there is no change in tag, else it builds and pushes rolling, latest, vX.Y.Z

Review guidelines

Estimated Time of Review: 10 minutes

Checklist before merging:

  • Confirm that the relevant changelog(s) are up-to-date in case of any user-facing changes

id: parse-tag
with:
fetch-depth: 2
- id: versions
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jjenscodee example of how you can compare versions with the new workflow

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks:+1:

Copy link
Member

@eeberhard eeberhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, always hard to be sure but we can fix any problems in post if necessary :)

@domire8 domire8 merged commit 06b8bc8 into develop Oct 23, 2023
4 checks passed
@domire8 domire8 deleted the feature/update-workflows branch October 23, 2023 09:39
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants