feat: migrate communication interfaces #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domire8
commented
May 1, 2024
|
This seems to link the libraries correctly, tested with the ZMQ lightweight interface in HC. If we merge this, it will release a new version 8.1.0 |
eeberhard
approved these changes
May 5, 2024
There was a problem hiding this comment.
Looks good to me! This has been something we have discussed for a while and I think it's well worth it.
This will essentially deprecate https://github.com/aica-technology/network-interfaces once downstream users switch to v8.1.
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Review by commit: First commit, I added (without changes, except the CMakeLists.txt) all sources from communication libraries. Second commit, I updated all necessary existing files to account for a new module in the build system.
We can either merge this and check the
rollingimage across the stack or i can make some local builds and test it this way.Review guidelines
Estimated Time of Review: 5 minutes
Checklist before merging: