Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add metadata to docker image #73

Merged
merged 2 commits into from
May 6, 2024
Merged

feat: add metadata to docker image #73

merged 2 commits into from
May 6, 2024

Conversation

LouisBrunner
Copy link
Contributor

Description

Part of https://github.com/aica-technology/ops/issues/333

This requires aica-technology/docker-images#104

@domire8 what's the process to release this library?

Review guidelines

Estimated Time of Review: 4 minutes

Checklist before merging:

  • Confirm that the relevant changelog(s) are up-to-date in case of any user-facing changes

@LouisBrunner LouisBrunner self-assigned this Apr 30, 2024
@domire8
Copy link
Member

domire8 commented Apr 30, 2024

I have to double check, but there are currently breaking changes on main, so we have to increase the major version.

Also, the goal was to transfer this to control-libraries at some point.

@LouisBrunner
Copy link
Contributor Author

Also, the goal was to transfer this to control-libraries at some point.

I don't mind that but it would be nice to release it so we can unblock the rest of the stack, we can merge them later?

Copy link
Member

@domire8 domire8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can put that on main, the release build will happen if we create a tag/release notes.

Copy link
Member

@eeberhard eeberhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the short term.

Related future version of CL that will ultimately deprecate this repo:

@LouisBrunner LouisBrunner merged commit 79540b1 into main May 6, 2024
3 checks passed
@LouisBrunner LouisBrunner deleted the feat/meta branch May 6, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants