Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new ASE version uses f-strings but is installed under python 3.5 #4295

Closed
ltalirz opened this issue Aug 10, 2020 · 4 comments
Closed

new ASE version uses f-strings but is installed under python 3.5 #4295

ltalirz opened this issue Aug 10, 2020 · 4 comments

Comments

@ltalirz
Copy link
Member

ltalirz commented Aug 10, 2020

See CI failure https://github.com/aiidateam/aiida-core/runs/965898145?check_suite_focus=true#step:11:334

It looks like this is an issue of ASE itself - README says python3.6 or later, but pypi metadata includes 3.5.

@ltalirz
Copy link
Member Author

ltalirz commented Aug 10, 2020

Opened issue https://gitlab.com/ase/ase/-/issues/718

@greschd
Copy link
Member

greschd commented Aug 10, 2020

As far as I understand, the PyPI metadata (Trove classifiers) aren't taken into account when choosing which version to install at all. The correct way to declare this incompatibility would be a python_requires in setup.py - which ASE doesn't seem to be doing at all, see https://gitlab.com/ase/ase/-/blob/master/setup.py

Crucially, the python_requires needs to be set already one version before the compatibility is dropped - i.e., only if there is a released version with python_requires>=3.5 will it install that if the newest version has >=3.6.

@ltalirz
Copy link
Member Author

ltalirz commented Aug 10, 2020

Thanks @greschd , linked in the issue!

@csadorf csadorf added topic/dependencies topic/dependencies/constraint Issues related to dependency constraints that should be resolved. labels Aug 10, 2020
csadorf added a commit to csadorf/aiida-core that referenced this issue Aug 10, 2020
csadorf added a commit that referenced this issue Aug 10, 2020
@csadorf
Copy link
Contributor

csadorf commented Aug 12, 2020

The issue is resolved by recent ase patch releases.

@csadorf csadorf closed this as completed Aug 12, 2020
@csadorf csadorf removed the topic/dependencies/constraint Issues related to dependency constraints that should be resolved. label Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants