Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: unpin python version #4290

Merged
merged 2 commits into from
Aug 12, 2020
Merged

Conversation

ltalirz
Copy link
Member

@ltalirz ltalirz commented Aug 6, 2020

The virtual environment of runners on Github Actions had an issue, where
installing a different pyyaml version than the one present resulted in
an error.
The issue has been resolved in the latest image, and so the workaround
of specifically requesting the (outdated) python version 3.7.7 can be
dropped.

See actions/runner-images#1202 (comment)

The virtual environment of runners on Github Actions had an issue, where
installing a different pyyaml version than the one present resulted in
an error.
The issue has been resolved in the latest image, and so the workaround
of specifically requesting the (outdated) python version 3.7.7 can be
dropped.
@ltalirz ltalirz requested a review from csadorf August 6, 2020 20:14
@codecov
Copy link

codecov bot commented Aug 6, 2020

Codecov Report

Merging #4290 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4290   +/-   ##
========================================
  Coverage    79.23%   79.23%           
========================================
  Files          468      468           
  Lines        34559    34559           
========================================
  Hits         27380    27380           
  Misses        7179     7179           
Flag Coverage Δ
#django 71.14% <ø> (ø)
#sqlalchemy 72.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fdcf0f...0b510a2. Read the comment docs.

@csadorf
Copy link
Contributor

csadorf commented Aug 10, 2020

Let's merge this after #4295 is fixed.

@csadorf csadorf merged commit 153cc5f into aiidateam:develop Aug 12, 2020
@csadorf
Copy link
Contributor

csadorf commented Aug 12, 2020

Thank you @ltalirz !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants