Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install aiida in conda environment, fix problem with .bashrc #3745

Merged
merged 5 commits into from
Feb 7, 2020
Merged

Install aiida in conda environment, fix problem with .bashrc #3745

merged 5 commits into from
Feb 7, 2020

Conversation

yakutovicha
Copy link
Contributor

fixes #3739

to be merged after aiidateam/aiida-prerequisites#12

@yakutovicha yakutovicha requested a review from ltalirz February 6, 2020 19:16
@yakutovicha
Copy link
Contributor Author

the tests should fail because aiidateam/aiida-prerequisites#12 is not yet merged

@ltalirz
Copy link
Member

ltalirz commented Feb 6, 2020

actually, the tests didn't fail.
is that a problem?

@yakutovicha yakutovicha marked this pull request as ready for review February 7, 2020 05:16
@yakutovicha
Copy link
Contributor Author

I thought conda activation part should make it fail since conda wasn't present. But it didn't do so apparently.

@yakutovicha
Copy link
Contributor Author

@ltalirz, I am going to revert the previous commit, but do you have any idea why it doesn't work as expected? It puzzles me a little bit.

@yakutovicha
Copy link
Contributor Author

yakutovicha commented Feb 7, 2020

@ltalirz I've added to the tests docker logs, so that we can be sure that things run under conda. Please review.

@ltalirz
Copy link
Member

ltalirz commented Feb 7, 2020

@ltalirz, I am going to revert the previous commit, but do you have any idea why it doesn't work as expected?

Without looking deep, the error is "docker exec" requires at least 2 arguments., i.e. it looks like for some reason $DOCKERID was empty.

Copy link
Member

@ltalirz ltalirz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, looks good to me!

@yakutovicha yakutovicha merged commit 48573df into aiidateam:develop Feb 7, 2020
@yakutovicha yakutovicha deleted the migrate_docker_to_conda branch February 7, 2020 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collect issues for the docker container.
2 participants