-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install aiida in conda environment, fix problem with .bashrc #3745
Install aiida in conda environment, fix problem with .bashrc #3745
Conversation
the tests should fail because aiidateam/aiida-prerequisites#12 is not yet merged |
actually, the tests didn't fail. |
I thought conda activation part should make it fail since conda wasn't present. But it didn't do so apparently. |
@ltalirz, I am going to revert the previous commit, but do you have any idea why it doesn't work as expected? It puzzles me a little bit. |
@ltalirz I've added to the tests |
Without looking deep, the error is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, looks good to me!
fixes #3739
to be merged after aiidateam/aiida-prerequisites#12