This repository has been archived by the owner on Feb 21, 2023. It is now read-only.
Correct error message on sentinel discovery of master/slave with password. #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azinoviev
force-pushed
the
feature/sentinel-passwd-fix
branch
from
7be374c to
599bbab
Compare
Codecov Report
@@ Coverage Diff @@
## master #284 +/- ##
==========================================
+ Coverage 96.83% 96.85% +0.02%
==========================================
Files 59 59
Lines 7553 7577 +24
Branches 599 603 +4
==========================================
+ Hits 7314 7339 +25
- Misses 174 175 +1
+ Partials 65 63 -2
Continue to review full report at Codecov.
|
…word. Pyenv's .python-version config added to .gitignore.
azinoviev
force-pushed
the
feature/sentinel-passwd-fix
branch
from
599bbab to
117bbbe
Compare
|
Closing this in favor of #327 (rebased and updated) |
popravich
added a commit
that referenced
this pull request
Nov 14, 2017
#284 Correct error message on sentinel discovery of master/slave with password
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help to get ReplyError "Master X error: ERR invalid password"/"Master X error: NOAUTH Authentication required." instead of MasterNotFoundError "No master found for X" when discovering password protected master/slave via Sentinel without password (or with wrong password) provided.
Pyenv's .python-version config added to .gitignore.