Skip to content
This repository has been archived by the owner on Feb 21, 2023. It is now read-only.

#284 Correct error message on sentinel discovery of master/slave with password #327

Merged
merged 3 commits into from
Nov 14, 2017

Conversation

popravich
Copy link
Contributor

Rebased from master;

Use more specific error kind.

@codecov
Copy link

codecov bot commented Nov 14, 2017

Codecov Report

Merging #327 into master will increase coverage by <.01%.
The diff coverage is 92.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #327      +/-   ##
==========================================
+ Coverage   96.77%   96.77%   +<.01%     
==========================================
  Files          55       55              
  Lines        7777     7811      +34     
  Branches      621      625       +4     
==========================================
+ Hits         7526     7559      +33     
- Misses        181      183       +2     
+ Partials       70       69       -1
Impacted Files Coverage Δ
aioredis/errors.py 100% <100%> (ø) ⬆️
tests/sentinel_commands_test.py 100% <100%> (ø) ⬆️
aioredis/sentinel/pool.py 86.21% <100%> (ø) ⬆️
tests/conftest.py 88.38% <66.66%> (-0.72%) ⬇️
tests/sentinel_failover_test.py 87.96% <0%> (+2.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ec600f...abee212. Read the comment docs.

@popravich
Copy link
Contributor Author

@azinoviev, your thoughts?

@popravich popravich force-pushed the feature/sentinel-passwd-fix branch 4 times, most recently from 856a556 to 15e04f6 Compare November 14, 2017 14:51
@popravich popravich merged commit fd7411a into master Nov 14, 2017
@popravich popravich deleted the feature/sentinel-passwd-fix branch November 14, 2017 15:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants