Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #10088/29c3ca93 backport][3.11] Avoid calling len on the same data in the stream reader twice #10090

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Dec 2, 2024

This is a backport of PR #10088 as merged into master (29c3ca9).

This is trivial but it is noticeable in the profile.

before
before

after
after

@bdraco bdraco enabled auto-merge (squash) December 2, 2024 01:07
Copy link

codspeed-hq bot commented Dec 2, 2024

CodSpeed Performance Report

Merging #10090 will not alter performance

Comparing patchback/backports/3.11/29c3ca93a4d1793c60d33038151228962f8b6f78/pr-10088 (849228d) with 3.11 (ae2b050)

Summary

✅ 44 untouched benchmarks

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.06%. Comparing base (ae2b050) to head (849228d).
Report is 1 commits behind head on 3.11.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.11   #10090   +/-   ##
=======================================
  Coverage   98.06%   98.06%           
=======================================
  Files         122      122           
  Lines       37051    37052    +1     
  Branches     4453     4453           
=======================================
+ Hits        36334    36335    +1     
  Misses        540      540           
  Partials      177      177           
Flag Coverage Δ
CI-GHA 97.95% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.66% <100.00%> (+<0.01%) ⬆️
OS-Windows 94.57% <100.00%> (+<0.01%) ⬆️
OS-macOS 96.77% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 96.63% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 97.22% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 97.23% <100.00%> (-0.02%) ⬇️
Py-3.11.9 96.70% <100.00%> (+<0.01%) ⬆️
Py-3.12.7 97.72% <100.00%> (-0.01%) ⬇️
Py-3.13.0 97.72% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 96.56% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 97.14% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 96.70% <100.00%> (+<0.01%) ⬆️
VM-macos 96.77% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.66% <100.00%> (+<0.01%) ⬆️
VM-windows 94.57% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 86bb6ad into 3.11 Dec 2, 2024
33 checks passed
@bdraco bdraco deleted the patchback/backports/3.11/29c3ca93a4d1793c60d33038151228962f8b6f78/pr-10088 branch December 2, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant