Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #10088/29c3ca93 backport][3.11] Avoid calling len on the same data in the stream reader twice #10090

Merged
merged 1 commit into from
Dec 2, 2024
Merged

[PR #10088/29c3ca93 backport][3.11] Avoid calling len on the same data in the stream reader twice #10090

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions aiohttp/streams.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,8 +517,9 @@ def _read_nowait_chunk(self, n: int) -> bytes:
else:
data = self._buffer.popleft()

self._size -= len(data)
self._cursor += len(data)
data_len = len(data)
self._size -= data_len
self._cursor += data_len

chunk_splits = self._http_chunk_splits
# Prevent memory leak: drop useless chunk splits
Expand Down
Loading