Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #8074/33ccdfb0 backport][3.9] Improve validation in HTTP parser #8078

Conversation

Dreamsorcerer
Copy link
Member

Co-authored-by: Paul J. Dorn pajod@users.noreply.github.com
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) sviat@redhat.com
(cherry picked from commit 33ccdfb)

Co-authored-by: Paul J. Dorn <pajod@users.noreply.github.com>
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <sviat@redhat.com>
(cherry picked from commit 33ccdfb)
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jan 28, 2024
@Dreamsorcerer Dreamsorcerer enabled auto-merge (squash) January 28, 2024 16:57
Copy link

codecov bot commented Jan 28, 2024

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (0d945d1) 97.38% compared to head (f47d197) 97.29%.

Files Patch % Lines
tests/test_http_parser.py 62.66% 24 Missing and 4 partials ⚠️
aiohttp/http_parser.py 85.71% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              3.9    #8078      +/-   ##
==========================================
- Coverage   97.38%   97.29%   -0.09%     
==========================================
  Files         108      108              
  Lines       32500    32575      +75     
  Branches     3849     3872      +23     
==========================================
+ Hits        31650    31695      +45     
- Misses        647      672      +25     
- Partials      203      208       +5     
Flag Coverage Δ
CI-GHA 97.20% <66.29%> (-0.09%) ⬇️
OS-Linux 96.90% <66.29%> (-0.09%) ⬇️
OS-Windows 94.39% <66.29%> (-0.09%) ⬇️
OS-macOS 96.72% <66.29%> (-0.09%) ⬇️
Py-3.10.11 94.29% <66.29%> (-0.09%) ⬇️
Py-3.10.13 96.68% <66.29%> (-0.09%) ⬇️
Py-3.11.7 96.41% <66.29%> (-0.09%) ⬇️
Py-3.12.1 96.49% <66.29%> (-0.09%) ⬇️
Py-3.8.10 94.27% <66.29%> (-0.09%) ⬇️
Py-3.8.18 96.61% <66.29%> (-0.09%) ⬇️
Py-3.9.13 94.28% <66.29%> (-0.09%) ⬇️
Py-3.9.18 96.66% <66.29%> (-0.09%) ⬇️
Py-pypy7.3.15 96.20% <66.29%> (-0.09%) ⬇️
VM-macos 96.72% <66.29%> (-0.09%) ⬇️
VM-ubuntu 96.90% <66.29%> (-0.09%) ⬇️
VM-windows 94.39% <66.29%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer merged commit d33bc21 into 3.9 Jan 28, 2024
25 of 29 checks passed
@Dreamsorcerer Dreamsorcerer deleted the patchback/backports/3.9/33ccdfb0a12690af5bb49bda2319ec0907fa7827/pr-8074 branch January 28, 2024 17:09
@webknjaz webknjaz changed the title Improve validation in HTTP parser (#8074) [PR #8074/33ccdfb0 backport][3.9] Improve validation in HTTP parser Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant