-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix close race that prevented the close code from reaching the client #8680
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like that works.
need to do regression testing with Home Assistant and make sure everything is still covered |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8680 +/- ##
==========================================
- Coverage 97.98% 97.96% -0.03%
==========================================
Files 107 107
Lines 33825 33860 +35
Branches 3969 3970 +1
==========================================
+ Hits 33143 33170 +27
- Misses 505 513 +8
Partials 177 177
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
manual testing looks good |
Backport to 3.10: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 4f41d05 on top of patchback/backports/3.10/4f41d05e1a1340303a92e77a166646af370291e8/pr-8680 Backporting merged PR #8680 into master
🤖 @patchback |
Backport to 3.11: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 4f41d05 on top of patchback/backports/3.11/4f41d05e1a1340303a92e77a166646af370291e8/pr-8680 Backporting merged PR #8680 into master
🤖 @patchback |
…lose code from reaching the client (#8687)
…lose code from reaching the client (#8686)
Fix close race that prevented the close code from reaching the client
fixes #3448