Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #8680/4f41d05 backport][3.11] Fix close race that prevented the close code from reaching the client #8687

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Aug 12, 2024

(cherry picked from commit 4f41d05)

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Aug 12, 2024
@bdraco bdraco changed the title Fix close race that prevented the close code from reaching the client (#8680) [PR #8680/4f41d05 backport][3.11] Fix close race that prevented the close code from reaching the client Aug 12, 2024
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (3.11@1500a53). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.11    #8687   +/-   ##
=======================================
  Coverage        ?   97.70%           
=======================================
  Files           ?      108           
  Lines           ?    34050           
  Branches        ?     4048           
=======================================
  Hits            ?    33268           
  Misses          ?      585           
  Partials        ?      197           
Flag Coverage Δ
CI-GHA 97.60% <100.00%> (?)
OS-Linux 97.28% <100.00%> (?)
OS-Windows 94.80% <100.00%> (?)
OS-macOS 96.94% <100.00%> (?)
Py-3.10.11 97.04% <100.00%> (?)
Py-3.10.14 96.99% <100.00%> (?)
Py-3.11.9 97.23% <100.00%> (?)
Py-3.12.4 97.33% <100.00%> (?)
Py-3.8.10 94.42% <100.00%> (?)
Py-3.8.18 96.77% <100.00%> (?)
Py-3.9.13 96.92% <97.82%> (?)
Py-3.9.19 96.88% <97.82%> (?)
Py-pypy7.3.16 96.47% <100.00%> (?)
VM-macos 96.94% <100.00%> (?)
VM-ubuntu 97.28% <100.00%> (?)
VM-windows 94.80% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review August 12, 2024 14:39
@bdraco bdraco merged commit 52581e8 into 3.11 Aug 12, 2024
33 of 34 checks passed
@bdraco bdraco deleted the patchback/backports/3.11/4f41d05e1a1340303a92e77a166646af370291e8/pr-8680 branch August 12, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant