Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump UP Version to 1.0.0 #43

Merged
merged 6 commits into from
Nov 30, 2023
Merged

Bump UP Version to 1.0.0 #43

merged 6 commits into from
Nov 30, 2023

Conversation

franklinselva
Copy link
Member

@franklinselva franklinselva commented Nov 24, 2023

Closes #38

I have bumped the UP dependency to 1.0 and adapted the related changes.

  • One option that has been removed from the test cases during this transition is the creation of the fluents with RealType parameters
# Using UP 1.0.0
from unified_planning.shortcuts import *
some_param = RealType(0,100)
f = Fluent("robot", RealType(0,100), param=some_param)
"""
Raises

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/lib/python3.8/site-packages/unified_planning/model/fluent.py", line 82, in __init__
    raise UPTypeError(
unified_planning.exceptions.UPTypeError: Parameter real[0, 100] param of fluent robot has type real[0, 100]; fluents parameters must have finite domains.
"""
  • I have relaxed the versions for the up planners that were available previously. From now, engines can be installed using pip install "up-esb[engines]"
  • I have also bumped the version of up-esb to 0.1.0

@franklinselva franklinselva marked this pull request as ready for review November 24, 2023 12:38
dev = ["black", "mypy", "pylint", "pytest", "pre-commit"]
engines = [
"up-aries",
# "up-fast-downward>=0.3.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented out on purpose? Seems fine for an optional dependency.

@franklinselva franklinselva merged commit 059edac into master Nov 30, 2023
1 check passed
@franklinselva franklinselva deleted the bump-up-version branch November 30, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update UP dependency to version 1
3 participants