This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
cherry pick: notify deprecation, tab limit increase, clean up log field #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
approved these changes
Jul 18, 2018
Codecov Report
@@ Coverage Diff @@
## airbnb-master #64 +/- ##
=================================================
+ Coverage 65.61% 65.62% +<.01%
=================================================
Files 346 350 +4
Lines 21847 21867 +20
Branches 2421 2431 +10
=================================================
+ Hits 14336 14351 +15
- Misses 7500 7504 +4
- Partials 11 12 +1
Continue to review full report at Codecov.
|
|
I'm going to hold off on merging this until next week when I'll have time to test it properly. |
williaster
force-pushed
the
chris--webpack4-notify-tabs-logs
branch
from
f58c33d
to
8572e62
Compare
* [toasts] get rid of notify globals, refactor messageToasts for use by entire app * [remove notify] use arrow func in ajax call * fix lint + tests * actually fix tests from messageToast refactor * add 'test:one' npm script * debugger * [toasts] convert bootstrap flash messages to toasts in explore + sqllab * [toasts][tests] import from right file
williaster
force-pushed
the
chris--webpack4-notify-tabs-logs
branch
from
8572e62
to
30248ef
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cherry-picks the following PRs from apache superset
@john-bodley @graceguo-supercat