This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Cherry pick webpack bundle (4 PRs) #65
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graceguo-supercat
changed the title
(cherry picked from commit ad05700)
(cherry picked from commit 0d10cc5)
* [toasts] get rid of notify globals, refactor messageToasts for use by entire app * [remove notify] use arrow func in ajax call * fix lint + tests * actually fix tests from messageToast refactor * add 'test:one' npm script * debugger * [toasts] convert bootstrap flash messages to toasts in explore + sqllab * [toasts][tests] import from right file (cherry picked from commit 19ac6e1)
(cherry picked from commit 7670e0c)
* [perf] add webpack 4 + SplitChunks + lazy load visualizations (apache#5240) * [webpack] setup lazy loading for all visualizations * [lazy-load] push renderVis function to <Chart /> state * no mapbox token * [lazy loading] use native webpack import func to fix chunk names, add babel-plugin-syntax-dynamic-import, fix rebase bug. * fix geojson import, undefined t, and fix async css bug * [lazy load] actually add babel-plugin-syntax-dynamic-import * [webpack] working dev version of webpack v4 * [webpack 4] fix url issues, use mini-css-extract-plugin and webpack-assets-manifest plugins * [webpack 4] use splitchunks for all files, update templates to multi-file entrypoints * [webpack 4] multiple theme entry files for markup vis css, don't uglify mapbox * [webpack 4] lint python manifest changes, update yarn lock. * [webpack 4] fix tests with babel-plugin-dynamic-import-node * [webpack 4] only use 'dynamic-import-node' plugin in tests, update <Chart /> vis promise when vis type changes * [webpack 4] clean up package.json and yarn.lock after rebase * [webpack 4] lint? * [webpack 4] lint for real * [webpack 4][istanbul] ignore visualizations/index.js * [webpack 4] fix rebase bug, update dashboard/deprecated/chart/Chart.jsx to use vis promises. * [webpack 4] lint and test * [webpack 4] yarn.lock (cherry picked from commit 8b7aaec)
graceguo-supercat
force-pushed
the
gg-TestWebpack
branch
from
62fc77b
to
f8c9401
Compare
|
will deploy #64 |
michellethomas
pushed a commit
that referenced
this pull request
Dec 1, 2021
michellethomas
pushed a commit
that referenced
this pull request
Dec 1, 2021
* fix: word cloud import bug * fix: add core-js
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick 4 PRs:
apache#5370, apache#5411, apache#5329, apache#5355