Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Cherry-picks: Update SQL Lab #94

Merged
merged 2 commits into from
Aug 20, 2018

Conversation

kristw
Copy link

@kristw kristw commented Aug 20, 2018

Cherry-pick the following commit(s):

SHA Time Log Author
cdd348a Sun Aug 19 22:43:00 2018 -0700 Minor improvements to SQL Lab UI (apache#5662) (origin/master, origin/HEAD, apache/master, master) [Krist Wongsuphasawat]
3d15d91 Fri Aug 17 17:44:56 2018 -0700 [sqllab] call out transient state of tabs to users (apache#5652) [Chris Williams]

@john-bodley @conglei @graceguo-supercat @kristw @michellethomas @timifasubaa @williaster

williaster and others added 2 commits August 20, 2018 10:42
* Remove "for"

* add space

* Separate control to select table from database and schema.

* Adjust schema displays

* Fix caret and arrow position in Select and Tab

* Reduce space after caret in tab header

* Use translator

* Align icons in the pop-up menu in Sql Lab

* Add new table in front of the list (so it will appear on top)

* shorten message

* reduce line

(cherry picked from commit cdd348a)
@kristw kristw changed the title [WIP] Cherry-pick(s): <description> Cherry-picks: Update to SQL Lab Aug 20, 2018
@kristw kristw changed the title Cherry-picks: Update to SQL Lab Cherry-picks: Update SQL Lab Aug 20, 2018
@codecov-io
Copy link

Codecov Report

Merging #94 into airbnb-master will increase coverage by <.01%.
The diff coverage is 94.11%.

Impacted file tree graph

@@                Coverage Diff                @@
##           airbnb-master      #94      +/-   ##
=================================================
+ Coverage          63.25%   63.25%   +<.01%     
=================================================
  Files                351      351              
  Lines              22034    22036       +2     
  Branches            2468     2470       +2     
=================================================
+ Hits               13937    13939       +2     
  Misses              8085     8085              
  Partials              12       12
Impacted Files Coverage Δ
...t/assets/src/SqlLab/components/CopyQueryTabUrl.jsx 78.57% <ø> (ø) ⬆️
...uperset/assets/src/SqlLab/components/SouthPane.jsx 88.57% <ø> (ø) ⬆️
...ets/src/SqlLab/components/TemplateParamsEditor.jsx 91.83% <ø> (ø) ⬆️
...rset/assets/src/SqlLab/components/TableElement.jsx 95.23% <ø> (ø) ⬆️
.../assets/src/SqlLab/components/SqlEditorLeftBar.jsx 92.52% <100%> (ø) ⬆️
superset/assets/src/SqlLab/reducers.js 58.18% <100%> (ø) ⬆️
superset/assets/src/reduxUtils.js 75.4% <100%> (+0.83%) ⬆️
.../assets/src/SqlLab/components/TabbedSqlEditors.jsx 91.74% <90.9%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 296ab20...136b5d0. Read the comment docs.

Copy link

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for including my commit! 😁

@kristw kristw merged commit 64e8e0d into airbnb:airbnb-master Aug 20, 2018
@kristw kristw deleted the kristw-cherry-sql-lab branch August 22, 2018 18:14
michellethomas pushed a commit that referenced this pull request Dec 1, 2021
Updates the requirements on [@data-ui/xy-chart](https://github.com/williaster/data-ui) to permit the latest version.
- [Release notes](https://github.com/williaster/data-ui/releases)
- [Changelog](https://github.com/williaster/data-ui/blob/master/CHANGELOG.md)
- [Commits](https://github.com/williaster/data-ui/commits/v0.0.78)

Signed-off-by: dependabot[bot] <support@dependabot.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants