[sqllab] call out transient state of tabs to users #5652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williaster
commented
Aug 17, 2018
| autorun: false, | ||
| sql: 'SELECT ...', | ||
| sql: `${t( |
There was a problem hiding this comment.
this is the only functional change
Codecov Report
@@ Coverage Diff @@
## master #5652 +/- ##
======================================
Coverage 63.5% 63.5%
======================================
Files 360 360
Lines 22888 22888
Branches 2549 2549
======================================
Hits 14534 14534
Misses 8339 8339
Partials 15 15
Continue to review full report at Codecov.
|
|
LGTM |
kristw
pushed a commit
to kristw/incubator-superset
that referenced
this pull request
Aug 20, 2018
(cherry picked from commit 3d15d91)
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent global notifications refactor (#5355) changed redux state such that users lost their SQL lab tabs.
We realized it's not necessarily clear to users that this state is transient (as it currently is implemented with local storage) so we wanted to add a note in the empty tab:
I have prettier ✨ enabled in my IDE so there are some auto-format changes from that.
@kristw @john-bodley @michellethomas @graceguo-supercat