-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TooltipWithBounds bug #767
Comments
@terpimost sorry for the delay, agree this is likely a bug! would happily review a PR 😁 |
Hey @williaster may I remove the line? I'm new to open-source and I think I can do this! |
@singhanurag05 go ahead and remove the line |
Hi @terpimost can you please check PR #828 I did it. |
Its not up to me to check PRs in that repo, lets wait.
On October 1, 2020, Gary Kahn ***@***.***> wrote:
Hi @terpimost <https://github.com/terpimost> can you please check PR
#828 <#828> I did it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#767 (comment)>, or
unsubscribe <https://github.com/notifications/unsubscribe-
auth/AAOQVTJ5HYOUZSFPMBDTGB3SISJCVANCNFSM4PFG73HA>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think in TooltipWithBounds the line unstyled={unstyled} should be deleted because we checking styles in the style property
With that line if I use unstyled TooltipWithBounds no position will be set because inside ToolTip no styles will be set at all because they should be taken from TooltipWithBounds.
https://github.com/hshoff/vx/blob/8ede587c3cc47d56736bc58f99e3d8a94a1e0850/packages/vx-tooltip/src/tooltips/TooltipWithBounds.tsx#L53
The text was updated successfully, but these errors were encountered: