fix TooltipWithBounds positioning

[heyanurag]

🐛 Bug Fix

• This PR should close TooltipWithBounds bug #767
  Please correct me if I did something wrong as I am new to Open Source.

[coveralls]

Pull Request Test Coverage Report for Build 293983229

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 36 unchanged lines in 8 files lost coverage.
• Overall coverage increased (+2.3%) to 56.685%

---

Files with Coverage Reduction	New Missed Lines	%
packages/visx-pattern/src/patterns/Lines.tsx	1	85.0%
packages/visx-xychart/src/classes/DataRegistry.ts	1	78.26%
packages/visx-xychart/src/components/XYChart.tsx	2	92.5%
packages/visx-xychart/src/hooks/useScales.ts	3	73.08%
packages/visx-responsive/src/enhancers/withParentSize.tsx	5	58.06%
packages/visx-xychart/src/components/series/LineSeries.tsx	5	41.38%
packages/visx-xychart/src/hooks/useDataRegistry.ts	6	45.45%
packages/visx-responsive/src/components/ParentSize.tsx	13	0.0%

Totals
Change from base Build 24:	2.3%
Covered Lines:	1250
Relevant Lines:	2133

---

💛 - Coveralls

[heyanurag]

@williaster Was this correct or not? Did I do something wrong? Please reply.

[williaster]

hey @singhanurag05 thanks for the fix! just to check I pulled this branch and played with it locally, then realized that the ideal solution is a bit more complicated.

I opened #831 with what I think is the needed fix. If you'd like to implement this yourself for more coding experience I'm happy to close it if you make those updates! Otherwise we can close this PR and use that one.

[heyanurag]

I had thought of the exact same thing! please let me do this @williaster

[williaster]

@singhanurag05 great! One comment on my changes: let's not set position: 'absolute' by default as this would be a breaking change. This means that when you set unstyled, you must set .visx-tooltip { position: absolute; } for correct positioning but we want to improve this in another PR in a non-breaking way.

[heyanurag]

@williaster Sorry I didn't get you. Can you please explain?

[williaster]

In my PR I made the change to remove position: absolute from defaultStyles, and always set it in Tooltip. This is technically needed for the tooltip positioning to work properly (without it, consumers who set unstyled must set their own css style rule .visx-tooltip { position: absolute; }), but it's technically a breaking change (which would require a 2.0 release).

so if you mirror the changes in my PR, I just meant to not make that change (i.e., leave position: absolute in defaultStyles, and don't apply it in Tooltip). make sense?

[heyanurag]

Absolutely yes! i'll make the changes in sometime. Thanks for the help!

[williaster]

Looks good to me! had one last suggestion but then I think this is good to go.

[heyanurag]

Thank you! Hope to contribute further.