-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add docker compose migration #40
Conversation
defer func() { d.stopContainer(ctx, conTransform.ID) }() | ||
|
||
// TODO figure out a better way to determine when the container has successfully started | ||
time.Sleep(10 * time.Second) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm concerned that with slower internet connections, this might not be enough time. Can we write a simple waitForStatus(id, status, timeout)
helper that could be used here? and further down. It looks like below there is an implementation of just such a loop in exec()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to handle this in a follow-up PR. Get this beast of a PR merged in first.
Few small comments, and a suggestion for the |
--migrate
flag to thelocal install
command (see diagram below for workflow of how this works)--persisted
flag tolocal uninstall
to remove persisted datainstall
-v
is enabledTODO