feat: consolidate paths into paths package
#41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perangel
approved these changes
Jun 26, 2024
| @@ -209,8 +209,7 @@ func (d *Docker) MigrateComposeDB(ctx context.Context, volume string) error { | |||
| pterm.Debug.Println(fmt.Sprintf("Created initial migration container '%s'", conCopy.ID)) | |||
|
|
|||
| // docker cp [conCopy.ID]]:/$migratePGDATA/. ~/.airbyte/abctl/data/airbyte-volume-db/pgdata | |||
| userHome, _ := os.UserHomeDir() | |||
| dst := filepath.Join(userHome, ".airbyte", "abctl", "data", "airbyte-volume-db", "pgdata") | |||
| dst := filepath.Join(paths.Data, "airbyte-volume-db", "pgdata") | |||
There was a problem hiding this comment.
I like where this is going, i think we could go even a little further and add some convenience methods like ensureDir, ensureFile, etc. All of which would be relative to $HOME/.airbyte
There was a problem hiding this comment.
That's the plan, but I'll do that as part of a follow-up PR (after #40 has been merged)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.