🪟 🔧 Increase color palette consistency: prohibit to use hex value for…

… colors (#16662)
airbytehq · Sep 14, 2022 · 144d1ec · 144d1ec
1 parent 835ff30
commit 144d1ec
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 2 deletions.
diff --git a/airbyte-webapp/.stylelintrc b/airbyte-webapp/.stylelintrc
@@ -12,7 +12,8 @@
     "scss/dollar-variable-empty-line-before": null,
     "scss/dollar-variable-pattern": null,
     "scss/percent-placeholder-pattern": null,
-    "value-keyword-case": null
+    "value-keyword-case": null,
+    "color-no-hex": true
   },
   "ignoreFiles": ["**/build/**", "**/dist/**"]
 }
diff --git a/airbyte-webapp/public/index.css b/airbyte-webapp/public/index.css
@@ -1,3 +1,4 @@
+/* stylelint-disable color-no-hex */
 body, html {
     margin: 0;
     height: 100%;

diff --git a/airbyte-webapp/src/components/base/Card/Card.module.scss b/airbyte-webapp/src/components/base/Card/Card.module.scss
@@ -1,4 +1,5 @@
 @use "../../../scss/colors";
+@use "../../../scss/variables" as vars;
 
 .container {
   width: auto;
@@ -18,7 +19,7 @@
 .title {
   padding: 25px 25px 22px;
   color: colors.$dark-blue;
-  border-bottom: #e8e8ed 1px solid;
+  border-bottom: colors.$grey-100 vars.$border-thin solid;
   font-weight: 600;
   letter-spacing: 0.008em;
   border-top-left-radius: 10px;

diff --git a/airbyte-webapp/src/packages/cloud/views/auth/OAuthLogin/OAuthLogin.module.scss b/airbyte-webapp/src/packages/cloud/views/auth/OAuthLogin/OAuthLogin.module.scss
@@ -43,6 +43,7 @@
 }
 
 .github {
+  /* stylelint-disable-next-line color-no-hex */
   background: #333;
   color: colors.$white;
   border: none;

diff --git a/airbyte-webapp/src/scss/_colors.scss b/airbyte-webapp/src/scss/_colors.scss
@@ -1,3 +1,4 @@
+/* stylelint-disable color-no-hex */
 $blue-50: #eae9ff;
 $blue-100: #cbc8ff;
 $blue-200: #a6a4ff;