🪟 🔧 Increase color palette consistency: prohibit to use hex value for colors #16662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
dizel852
changed the title
timroes
reviewed
Sep 14, 2022
| @@ -12,7 +12,8 @@ | |||
| "scss/dollar-variable-empty-line-before": null, | |||
| "scss/dollar-variable-pattern": null, | |||
| "scss/percent-placeholder-pattern": null, | |||
| "value-keyword-case": null | |||
| "value-keyword-case": null, | |||
| "color-no-hex": true | |||
There was a problem hiding this comment.
🎉 That's a great addition to prevent mistakes, thanks.
timroes
reviewed
Sep 14, 2022
timroes
reviewed
Sep 14, 2022
airbyte-webapp/src/packages/cloud/views/auth/OAuthLogin/OAuthLogin.module.scss
Outdated
Show resolved
Hide resolved
timroes
approved these changes
Sep 14, 2022
This was referenced Sep 14, 2022
robbinhan
pushed a commit
to robbinhan/airbyte
that referenced
this pull request
Sep 29, 2022
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Increase color palette consistency: since we have agreed on a color palette we need to prohibit to use of hex color values.
How
Update stylelint config: add
"color-no-hex"ruleUnfortunately, we can't provide some custom text messages like:
"Please, use colors from _colors.scss"
Recommended reading order
All