-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🪟 🔧 Increase color palette consistency: prohibit to use hex value for colors #16662
Conversation
@@ -12,7 +12,8 @@ | |||
"scss/dollar-variable-empty-line-before": null, | |||
"scss/dollar-variable-pattern": null, | |||
"scss/percent-placeholder-pattern": null, | |||
"value-keyword-case": null | |||
"value-keyword-case": null, | |||
"color-no-hex": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 That's a great addition to prevent mistakes, thanks.
airbyte-webapp/src/packages/cloud/views/auth/OAuthLogin/OAuthLogin.module.scss
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM. Tested in editor locally. Strictly spoken this will still allow inline colors when using rgb
notation or a color name, but in the past most often we've seen people using hex values, so it's still a nice additional linting layer to have.
What
Increase color palette consistency: since we have agreed on a color palette we need to prohibit to use of hex color values.
How
Update stylelint config: add
"color-no-hex"
ruleUnfortunately, we can't provide some custom text messages like:
"Please, use colors from _colors.scss"
Recommended reading order
All