-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
🪟 🐛 Update connection name - fix minor issues (#13550)
* align text to center in edit mode * fix firing onChange event twice * fix wrong prop drilling * fix issues: - unable to delete last chart in input - delete the whole name by 'select all' command - trim entered names - don't allow to save empty names * remove debug from test * remove unused import * update tests due to changes in base Input component * reorder default input data-testId in order to have ability to overwrite it * fix e2e tests * Improvements: - replace "props: any" with right types - rename 'addEnterEscFuncForInput' to more general and self-describable name * replace styled components with scss modules * add eslint-plugin-css-modules rules * Fixes: - turn on eslint css modules rule as error - remove unused styles * minor fix after master merge * Revert "Fixes:" This reverts commit d7fb68a. * Revert "add eslint-plugin-css-modules rules" This reverts commit 0333a70. * apply suggested changes after PR review * add updates due to changes in PR #13914 * add react-app-rewired to tweak webpack config and fix the css order issue * remove test flag "CI=true" * Revert "add react-app-rewired to tweak webpack config and fix the css order issue" This reverts commit 81d7ba4
- Loading branch information
Showing
10 changed files
with
184 additions
and
148 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
84 changes: 84 additions & 0 deletions
84
...p/src/pages/ConnectionPage/pages/ConnectionItemPage/components/ConnectionName.module.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,84 @@ | ||
@use "../../../../../scss/colors"; | ||
@use "../../../../../scss/variables"; | ||
|
||
.container { | ||
margin-top: variables.$spacing-m; | ||
display: flex; | ||
align-items: center; | ||
justify-content: center; | ||
} | ||
|
||
.textContainer { | ||
width: 650px; | ||
display: flex; | ||
align-items: center; | ||
justify-content: center; | ||
position: relative; | ||
} | ||
|
||
.nameContainer { | ||
composes: textContainer; | ||
background-color: colors.$beige-100; | ||
border: variables.$border-thin solid colors.$beige-100; | ||
border-radius: variables.$border-radius-sm; | ||
padding: 0 variables.$spacing-xl; | ||
|
||
div { | ||
width: 100%; | ||
|
||
h2 { | ||
font-weight: 700; | ||
font-size: 24px; | ||
line-height: 29px; | ||
text-align: center; | ||
color: colors.$dark-blue-900; | ||
margin: variables.$spacing-m; | ||
word-wrap: break-word; | ||
} | ||
} | ||
|
||
&:hover { | ||
cursor: pointer; | ||
border: variables.$border-thin solid colors.$blue; | ||
background-color: colors.$blue-50; | ||
|
||
& > .icon { | ||
display: block; | ||
} | ||
} | ||
} | ||
|
||
.icon { | ||
display: none; | ||
position: absolute; | ||
right: variables.$spacing-xl; | ||
font-size: 18px; | ||
color: colors.$blue; | ||
} | ||
|
||
.editingContainer { | ||
composes: textContainer; | ||
background-color: colors.$white; | ||
border: variables.$border-thin solid colors.$blue; | ||
border-radius: variables.$border-radius-sm; | ||
} | ||
|
||
.inputContainer { | ||
height: 50px; | ||
width: 100%; | ||
|
||
div { | ||
border-radius: variables.$border-radius-sm; | ||
border: none; | ||
box-shadow: none; | ||
background-color: colors.$white !important; // fix style import order issue | ||
} | ||
} | ||
|
||
.input { | ||
border-radius: variables.$border-radius-sm; | ||
background-color: colors.$white; | ||
font-size: 24px !important; // fix style import order issue | ||
height: 50px; | ||
text-align: center; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.