Remove recreate source/destination as it is not used (#11199)

airbytehq · Mar 23, 2022 · eaf364e · eaf364e
1 parent 8771ba9
commit eaf364e
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 141 deletions.
diff --git a/airbyte-webapp/src/core/resources/Destination.tsx b/airbyte-webapp/src/core/resources/Destination.tsx
@@ -36,27 +36,6 @@ export class DestinationResource extends BaseResource implements Destination {
     };
   }
 
-  // TODO: remove?
-  static recreateShape<T extends typeof Resource>(
-    this: T
-  ): MutateShape<SchemaDetail<Destination>> {
-    return {
-      ...super.updateShape(),
-      fetch: async (
-        _: Readonly<Record<string, string | number>>,
-        body: Record<string, unknown>
-      ): Promise<Destination> => {
-        const response = await this.fetch(
-          "post",
-          `${super.rootUrl()}web_backend/destinations/recreate`,
-          body
-        );
-        return response;
-      },
-      schema: this,
-    };
-  }
-
   static createShape<T extends typeof Resource>(
     this: T
   ): MutateShape<SchemaDetail<Destination>> {

diff --git a/airbyte-webapp/src/core/resources/Source.tsx b/airbyte-webapp/src/core/resources/Source.tsx
@@ -35,27 +35,6 @@ export class SourceResource extends BaseResource implements Source {
     };
   }
 
-  // TODO: fix detailShape here as it is actually createShape
-  // eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
-  // TODO: remove?
-  static recreateShape<T extends typeof Resource>(this: T) {
-    return {
-      ...super.detailShape(),
-      fetch: async (
-        _: Readonly<Record<string, string | number>>,
-        body: Readonly<Partial<Source>>
-      ): Promise<Source> => {
-        const response = await this.fetch(
-          "post",
-          `${super.rootUrl()}web_backend/sources/recreate`,
-          body
-        );
-        return response;
-      },
-      schema: this,
-    };
-  }
-
   static createShape<T extends typeof Resource>(
     this: T
   ): MutateShape<SchemaDetail<Source>> {

diff --git a/airbyte-webapp/src/hooks/services/useDestinationHook.tsx b/airbyte-webapp/src/hooks/services/useDestinationHook.tsx
@@ -41,13 +41,6 @@ type DestinationService = {
     values: ValuesProps;
     destinationConnector?: ConnectorProps;
   }) => Promise<Destination>;
-  recreateDestination: ({
-    values,
-    destinationId,
-  }: {
-    values: ValuesProps;
-    destinationId: string;
-  }) => Promise<Destination>;
   deleteDestination: ({
     destination,
     connectionsWithDestination,
@@ -73,8 +66,6 @@ const useDestination = (): DestinationService => {
     DestinationResource.partialUpdateShape()
   );
 
-  const recreatedestination = useFetcher(DestinationResource.recreateShape());
-
   const destinationDelete = useFetcher(DestinationResource.deleteShape());
 
   const updateConnectionsStore = useFetcher(
@@ -172,38 +163,6 @@ const useDestination = (): DestinationService => {
     );
   };
 
-  const recreateDestination = async ({
-    values,
-    destinationId,
-  }: {
-    values: ValuesProps;
-    destinationId: string;
-  }) => {
-    return await recreatedestination(
-      {
-        destinationId,
-      },
-      {
-        name: values.name,
-        destinationId,
-        connectionConfiguration: values.connectionConfiguration,
-        workspaceId: workspace.workspaceId,
-        destinationDefinitionId: values.serviceType,
-      },
-      // Method used only in onboarding.
-      // Replace all destination List to new item in UpdateParams (to change id)
-      [
-        [
-          DestinationResource.listShape(),
-          { workspaceId: workspace.workspaceId },
-          (newdestinationId: string) => ({
-            destinations: [newdestinationId],
-          }),
-        ],
-      ]
-    );
-  };
-
   const checkDestinationConnection = useCallback(
     async ({
       destinationId,
@@ -248,7 +207,6 @@ const useDestination = (): DestinationService => {
   return {
     createDestination,
     updateDestination,
-    recreateDestination,
     deleteDestination,
     checkDestinationConnection,
   };

diff --git a/airbyte-webapp/src/hooks/services/useSourceHook.tsx b/airbyte-webapp/src/hooks/services/useSourceHook.tsx
@@ -22,10 +22,6 @@ type ValuesProps = {
 type ConnectorProps = { name: string; sourceDefinitionId: string };
 
 type SourceService = {
-  recreateSource: (recreateSourcePayload: {
-    values: ValuesProps;
-    sourceId: string;
-  }) => Promise<Source>;
   checkSourceConnection: (checkSourceConnectionPayload: {
     sourceId: string;
     values?: ValuesProps;
@@ -56,8 +52,6 @@ const useSource = (): SourceService => {
 
   const updatesource = useFetcher(SourceResource.partialUpdateShape());
 
-  const recreatesource = useFetcher(SourceResource.recreateShape());
-
   const sourceDelete = useFetcher(SourceResource.deleteShape());
 
   const updateConnectionsStore = useFetcher(
@@ -160,35 +154,6 @@ const useSource = (): SourceService => {
     [sourceCheckConnectionShape]
   );
 
-  const recreateSource: SourceService["recreateSource"] = async ({
-    values,
-    sourceId,
-  }) => {
-    return await recreatesource(
-      {
-        sourceId: sourceId,
-      },
-      {
-        name: values.name,
-        sourceId,
-        connectionConfiguration: values.connectionConfiguration,
-        workspaceId: workspace.workspaceId,
-        sourceDefinitionId: values.serviceType,
-      },
-      // Method used only in onboarding.
-      // Replace all source List to new item in UpdateParams (to change id)
-      [
-        [
-          SourceResource.listShape(),
-          { workspaceId: workspace.workspaceId },
-          (newsourceId: string) => ({
-            sources: [newsourceId],
-          }),
-        ],
-      ]
-    );
-  };
-
   const deleteSource: SourceService["deleteSource"] = async ({
     source,
     connectionsWithSource,
@@ -214,7 +179,6 @@ const useSource = (): SourceService => {
   return {
     createSource,
     updateSource,
-    recreateSource,
     deleteSource,
     checkSourceConnection,
   };

diff --git a/airbyte-webapp/src/pages/OnboardingPage/OnboardingPage.tsx b/airbyte-webapp/src/pages/OnboardingPage/OnboardingPage.tsx
@@ -81,8 +81,8 @@ const OnboardingPage: React.FC = () => {
     {}
   );
 
-  const { createSource, recreateSource } = useSource();
-  const { createDestination, recreateDestination } = useDestination();
+  const { createSource } = useSource();
+  const { createDestination } = useDestination();
   const { finishOnboarding } = useWorkspace();
 
   const [successRequest, setSuccessRequest] = useState(false);
@@ -132,14 +132,7 @@ const OnboardingPage: React.FC = () => {
         const sourceConnector = getSourceDefinitionById(values.serviceType);
 
         try {
-          if (!!sources.length) {
-            await recreateSource({
-              values,
-              sourceId: sources[0].sourceId,
-            });
-          } else {
-            await createSource({ values, sourceConnector });
-          }
+          await createSource({ values, sourceConnector });
 
           setSuccessRequest(true);
           setTimeout(() => {
@@ -173,17 +166,10 @@ const OnboardingPage: React.FC = () => {
         );
 
         try {
-          if (!!destinations.length) {
-            await recreateDestination({
-              values,
-              destinationId: destinations[0].destinationId,
-            });
-          } else {
-            await createDestination({
-              values,
-              destinationConnector,
-            });
-          }
+          await createDestination({
+            values,
+            destinationConnector,
+          });
 
           setSuccessRequest(true);
           setTimeout(() => {