Remove recreate source/destination as it is not used #11199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/frontend
area/platform
timroes
reviewed
Mar 18, 2022
| @@ -173,17 +166,10 @@ const OnboardingPage: React.FC = () => { | |||
| ); | |||
|
|
|||
| try { | |||
| if (!!destinations.length) { | |||
There was a problem hiding this comment.
Since this seems to be the root place this was triggered, could you explain when this was triggered earlier, and why this is no longer happening in the app? I am not fully understanding the scenario where this happened and what the user-flow was when this was still in use.
There was a problem hiding this comment.
TBH I am also not sure when this was happening exactly, but as I remember in the past it was possible to go back and forward during onboarding. So we were recreating destination in some cases. After this functionality was disabled - this endpoint was never called.
timroes
approved these changes
Mar 23, 2022
This was referenced Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Minor code cleanup. Removes recreate call that is not used anymore.