Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement backoff in Google sheets #1353

Closed
sherifnada opened this issue Dec 16, 2020 · 0 comments
Closed

implement backoff in Google sheets #1353

sherifnada opened this issue Dec 16, 2020 · 0 comments
Assignees
Labels
type/bug Something isn't working

Comments

@sherifnada
Copy link
Contributor

sherifnada commented Dec 16, 2020

Expected Behavior

We often run into rate limiting with the GSheets integration which causes the integration tests to fail periodically. This is probably because we create/populate/destroy the sheet in every test. The integration should instead backoff appropriately when it runs into a rate limiting error.

Acceptance Criteria

Detect when the connector runs into rate limiting exceptions and backoff appropriately

@sherifnada sherifnada added type/enhancement New feature or request type/bug Something isn't working and removed type/enhancement New feature or request labels Dec 16, 2020
jrhizor pushed a commit that referenced this issue Dec 31, 2020
* Issue #1353: implement backoff for integration tests

* update code for backoff HTTP error while read Google Sheet

* create Client class for Google Sheets with backoff all methods

* update Google Sheets Source after review #2

* update docker version for google_sheets_source
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants