Resolving issue #1353: implement backoff in Google Sheets #1438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherifnada
reviewed
Dec 23, 2020
There was a problem hiding this comment.
@yevhenii-ldv This looks great so far, but we aren't backing off on every client call. For example in the discovery method we make a call using client but there is no backing off there as far as i can tell. Could we add this backoff to every call made with the client? It may make sense to put the client in a separate class if it helps.
|
@sherifnada PR was updated with new client`s class for Google Sheets requests with backoff |
sherifnada
suggested changes
Dec 25, 2020
There was a problem hiding this comment.
Merry christmas @yevhenii-ldv! looking much better already. Two more things needed:
- Update the version of this connector in the Dockerfile, YAML, and generated JSON file. We generally want to do this whenever we make an update to a connector so we can release a new version.
- small structural change to the client
airbyte-integrations/connectors/source-google-sheets/google_sheets_source/client.py
Show resolved
Hide resolved
Closed
|
@sherifnada I have updated the PR as per your comments. |
jrhizor
approved these changes
Dec 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Using a backoff in the Google Sheets source code when the request limit is reached.
How
Using python library
backoffPre-merge Checklist
Recommended reading order
test.javacomponent.ts