Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Pinterest: support oauth #7754

Closed
Tracked by #7000
lazebnyi opened this issue Nov 8, 2021 · 2 comments · Fixed by #16271
Closed
Tracked by #7000

Source Pinterest: support oauth #7754

lazebnyi opened this issue Nov 8, 2021 · 2 comments · Fixed by #16271
Assignees

Comments

@lazebnyi
Copy link
Collaborator

lazebnyi commented Nov 8, 2021

Tell us about the problem you're trying to solve

With the release of Airbyte Cloud, we need to start supporting Oauth for this connector, since it's the recommended way of authenticating users into a SaaS application.

If this connector doesn't support oauth already (i.e: doesn't accept a client_id and client_secret) then we need to update its spec to accept those parameters. There are two ways to do this:

If the connector already supports some auth mechanism like api_key, I suggest that this be a oneof nested inside a top-level field called "authentication":

{ authentication: { type: object oneOf: [ // api key, // oauth ] } }

If the connector only supports webflow oauth, then no changes are needed to the properties format and we will only need to add annotations.

See the connector spec reference in the docs for reference on how a oneof can be implemented.

This should be done in a backwards compatible manner i.e: users currently supplying authentication info in the config's top-level should not be impacted by this change.
##Acceptance criteria
The connector supports oauth webflow authentication with client_id/client_secret in a backwards compatible manner
Oauth properties are annotated properly.

@lazebnyi lazebnyi added type/enhancement New feature or request area/connectors Connector related issues requires-oauth connector which requires oauth labels Nov 8, 2021
@lazebnyi lazebnyi self-assigned this Nov 8, 2021
@lazebnyi lazebnyi changed the title Source Pinterest: Support Oauth Source Pinterest: support oauth Nov 8, 2021
@lazebnyi lazebnyi removed their assignment Jan 17, 2022
@ycherniaiev ycherniaiev added Epic and removed Epic labels Jun 17, 2022
@YowanR
Copy link
Contributor

YowanR commented Aug 4, 2022

@igrankova @ycherniaiev I wanted to check and see if there are any known issues around this connector with respect to getting a dev account/oauth? I know we haven't started the dev work yet but ideally everything else is ready to go :)

@ycherniaiev
Copy link
Contributor

@YowanR it is public but not advanced I mean the number of api calls is limited.Once it is on cloud it will be easier to request advanced oauth

@arsenlosenko arsenlosenko self-assigned this Aug 26, 2022
@arsenlosenko arsenlosenko linked a pull request Aug 31, 2022 that will close this issue
37 tasks
@arsenlosenko arsenlosenko removed a link to a pull request Sep 2, 2022
37 tasks
@arsenlosenko arsenlosenko linked a pull request Sep 2, 2022 that will close this issue
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Backlog (unscoped)
Development

Successfully merging a pull request may close this issue.

6 participants