-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Pinterest: support OAuth #16271
Source Pinterest: support OAuth #16271
Conversation
/test connector=connectors/source-pinterest
Build FailedTest summary info:
|
airbyte-integrations/connectors/source-pinterest/source_pinterest/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-pinterest/source_pinterest/source.py
Outdated
Show resolved
Hide resolved
9743a03
to
739fb0f
Compare
/test connector=connectors/source-pinterest
Build FailedTest summary info:
|
/test connector=connectors/source-pinterest
Build FailedTest summary info:
|
…ource-pinterest-support-oauth-cp
/test connector=connectors/source-pinterest
Build FailedTest summary info:
|
…duce API Calls for child streams, commented out Incremental and Full refresh SAT tests
…ource-pinterest-support-oauth-cp
/test connector=connectors/source-pinterest
Build FailedTest summary info:
|
/publish connector=connectors/source-pinterest run-tests=false
if you have connectors that successfully published but failed definition generation, follow step 4 here |
@arsenlosenko why were tests skipped here? |
/** | ||
* Following docs from https://developers.pinterest.com/docs/getting-started/authentication | ||
*/ | ||
public class PinterestOAuthFlow extends BaseOAuth2Flow { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arsenlosenko could you add unit tests for this function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sherifnada yes, already working on unit tests for this class in scope of this PR:
#16393
@sherifnada the tests were skipped due to low rate limits in Pinterest API (300 requests/day), due to that we couldn't run complete test suite here |
* Source Pinterest: Initial setup of OAuth flow * Remove previously added class and method for auth * Update Java part of OAuth flow, update spec * Update spec and add additional methods to Java OAuth flow * Add backwards compatibility for old config structure * Add missing imports * Revert previous changes in source_specs.yaml * Cleanup in imports and source_specs * Add missing imports * Add missing imports * Remove 'subdomain' logic from Java OAuth flow * Update docs * Update docs accordingly to comments in PR * Refactor credentials variable * Fix typo * Update acceptance-test-config.yml * Specify integer type for AD_ACCOUNT_ID value in schemas * updated SAT tests, fixed Max Rate Limit error handling * updated unit_tests * updated schemas, added caching for Boards and AdAccounts stream to reduce API Calls for child streams, commented out Incremental and Full refresh SAT tests * auto-bump connector version [ci skip] Co-authored-by: Oleksandr Bazarnov <oleksandr.bazarnov@globallogic.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
* Source Pinterest: Initial setup of OAuth flow * Remove previously added class and method for auth * Update Java part of OAuth flow, update spec * Update spec and add additional methods to Java OAuth flow * Add backwards compatibility for old config structure * Add missing imports * Revert previous changes in source_specs.yaml * Cleanup in imports and source_specs * Add missing imports * Add missing imports * Remove 'subdomain' logic from Java OAuth flow * Update docs * Update docs accordingly to comments in PR * Refactor credentials variable * Fix typo * Update acceptance-test-config.yml * Specify integer type for AD_ACCOUNT_ID value in schemas * updated SAT tests, fixed Max Rate Limit error handling * updated unit_tests * updated schemas, added caching for Boards and AdAccounts stream to reduce API Calls for child streams, commented out Incremental and Full refresh SAT tests * auto-bump connector version [ci skip] Co-authored-by: Oleksandr Bazarnov <oleksandr.bazarnov@globallogic.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
We got access to a higher rate limit for this account. Can we just run the test and make sure we are good now, please? |
What
Resolving:
#7754
How
Describe the solution
Recommended reading order
x.java
y.python
🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changesTests
Unit
Put your unit tests output here.
Integration
Put your integration tests output here.
Acceptance
Put your acceptance tests output here.