Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Pinterest: support OAuth #16165

Closed
wants to merge 41 commits into from
Closed

Source Pinterest: support OAuth #16165

wants to merge 41 commits into from

Conversation

arsenlosenko
Copy link
Contributor

What

Resolving:
#7754

How

Right now this is a WIP, pushing this to start review process

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

@arsenlosenko arsenlosenko self-assigned this Aug 31, 2022
@CLAassistant
Copy link

CLAassistant commented Aug 31, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the area/connectors Connector related issues label Aug 31, 2022
@arsenlosenko arsenlosenko linked an issue Aug 31, 2022 that may be closed by this pull request
Source Pinterest: support oauth #7754
Closed
@arsenlosenko arsenlosenko temporarily deployed to more-secrets August 31, 2022 10:40 Inactive
@arsenlosenko arsenlosenko temporarily deployed to more-secrets August 31, 2022 10:52 Inactive
ryankfu and others added 19 commits August 31, 2022 07:15
@ryankfu
Handle SQLSTATE Exception (08006) when reading records (#15869)
e560ed7
chore: cleanup dormant workflows (#16022)
cd2860f 
* chore: cleanup dormant workflows

* fix: restore performance test

* fix: add back GKE acceptance test

* ci: add cron to GKE Kube Acceptance Test
@sophia-wiley @Amruta-Ranade
Release Note Documentation (#16148)
732ec3c 
* added release notes file

* changed file name

* Added release notes

* Edited formatting and links

* Deleted extra lines and backticks

* Deleted extra spaces

Co-authored-by: Amruta Ranade <11484018+Amruta-Ranade@users.noreply.github.com>
@Amruta-Ranade
Update august_2022.md
bef1269
@sophia-wiley
Fixed release name
b9bba17 
Release name should have a dash instead of a period.
@rodireich @octavia-squidington-iii
enforce ssl in strict mysql and postgres source (#16114)
c6f876d 
* enforce ssl in strict mysql and postgres source

* Add test to verify tunnel aware strict SSL behavior

* bump version numbers and changelogs

* auto-bump connector version [ci skip]

* auto-bump connector version [ci skip]

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
@sophia-wiley
Edited July Release Notes (#16179)
86a5f90 
* Changed August to July in title, file, and sidebar

* deleted extra spaces
@Amruta-Ranade
Updated connector catalog page (#16181)
8998bad
@grubberr
CDK: Fix regression in _checkpoint_state arg (#16141)
3cfa489 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@Daemonxiao @zhangyangyu @marcosmarxm
🎉 New Destination: TiDB (#15592)
d452403 
* Add new destination-tidb

* support sync

* Add normalization-tidb

* fix failed tests

* Add unnest marco

* fmt

* Add new destination-tidb

* support sync

* Add normalization-tidb

* fix failed tests

* Add unnest marco

* fmt

* fmt

* fix integration test

* Update docs/integrations/destinations/tidb.md

Co-authored-by: Xiang Zhang <angwerzx@126.com>

* Update doc

* Update doc

* Update doc

* bump normalization version

* update normalization changelog

* run format

* add dest def

* generat spec

Co-authored-by: Xiang Zhang <angwerzx@126.com>
Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>
Co-authored-by: marcosmarxm <marcosmarxm@gmail.com>
@jhecking
Source Snowflake: Docs Fix invalid config examples (#16158)
e45709a
@edmundito
Ensure scheduleType gets updated when connection is updated (#16183)
a6b3d1f
@krishnaglick
Auth Button now shows re-authenticate when it has been authenticated …
4cec0ba 
…once (#15615)

* Auth Button now knows if the connection object is full or empty, and shows the expected value.

* Some types, better oauth finished calculation

* values => preparedValues

* Fixing test
@pedroslopez
Fix error finding PostgreSQLContainer in migration tasks (#16146)
944b168 
* mark libs.platform.testcontainers.postgresql as implementation dep

* use migrations configuration for mig task dependencies

* shuffle things around

* Update build.gradle
@alovew
Add protocol version migration (#16145)
827e7a5 
* Add protocol version migration
@davinchia
Docker Operational Improvements. (#16195)
35f4c6e 
- Clarify what resource requirements are merged.
- Add logging so in DockerProcessFactory.
@tuliren
📝 S3 source: update doc about path_prefix + path_pattern (#16206)
a475235 
* Add more explanation for path_prefix + path_pattern

* Simplify wording

* Update wording
@bazarnov
🐛 Source Tiktok: unnest cursor and primary key to the root-level (#…
3611e65 
…16137)
@suhomud
Destination Redshift: custom JDBC parameters (#16208)
5773c22
@arsenlosenko arsenlosenko requested review from a team as code owners September 2, 2022 11:38
@github-actions github-actions bot added area/documentation Improvements or additions to documentation area/platform issues related to the platform area/scheduler area/worker Related to worker CDK Connector Development Kit kubernetes normalization area/frontend Related to the Airbyte webapp labels Sep 2, 2022
@arsenlosenko arsenlosenko temporarily deployed to more-secrets September 2, 2022 11:40 Inactive
@arsenlosenko arsenlosenko removed a link to an issue Sep 2, 2022
Source Pinterest: support oauth #7754
Closed
@arsenlosenko
Copy link
Contributor Author

Closed due to messed up structure of the branch, cleaned up version of this PR is here:
#16271

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bazarnov bazarnov Awaiting requested review from bazarnov

@roman-yermilov-gl roman-yermilov-gl Awaiting requested review from roman-yermilov-gl

Assignees

@arsenlosenko arsenlosenko

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation area/frontend Related to the Airbyte webapp area/platform issues related to the platform area/scheduler area/worker Related to worker CDK Connector Development Kit connectors/destination/redshift connectors/destination/tidb connectors/source/amplitude connectors/source/mysql connectors/source/mysql-strict-encrypt connectors/source/oracle-strict-encrypt connectors/source/pinterest connectors/source/postgres connectors/source/postgres-strict-encrypt connectors/source/redshift connectors/source/relational-db connectors/source/snowflake connectors/source/tidb connectors/source/tiktok-marketing kubernetes normalization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.